Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snake_case field names #6262

Merged

Conversation

ghubstan
Copy link
Contributor

Be consistent, and x-language.

API reference doc needs snake_case proto msg field names (and so do non-java client devs who want to follow their language's field name conventions).

Based on master.

Be consistent, and x-language.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 590bb6c into bisq-network:master Jun 24, 2022
@ripcurlx ripcurlx added this to the v1.9.4 milestone Jun 24, 2022
@ghubstan ghubstan deleted the fix_snake_case_proto_field_name branch August 7, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants