Conditionally block API's send payment sent/rcvd msgs #6247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't depend on silent, UI purposed task runner errors if confirmpaymentstarted or confirmpaymentreceived msgs are sent outside the proper context. Throw a FailedPreconditionException instead, and it will be translated into the proper gPRC StatusRuntimeException before being sent to client. For BTC buyers and sellers, block the messaging attempt if the taker deposit tx has not been confirmed. For BTC sellers, block an attempt to send a confirmpaymentreceived message until after receiving a confirmpaymentstarted message has been sent from the buyer.
Replaced by BSQ Swaps, and will be deprecated.
- verifyPaymentSentMsgIsFromBtcBuyerPrecondition - verifyPaymentReceivedMsgIsFromBtcSellerPrecondition - verifyPaymentSentMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgAfterPaymentSentMsgPrecondition Changed a couple of related method names.
- verifyPaymentSentMsgIsFromBtcBuyerPrecondition - verifyPaymentReceivedMsgIsFromBtcSellerPrecondition - verifyPaymentSentMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgAfterPaymentSentMsgPrecondition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes API bug incorrectly permitting payment sent / received msgs before trade deposit tx is confirmed. Also blocks payment rcvd confirmation msgs from being sent if payment sent msgs have not been sent (yet). API cannot depend on silent, UI purposed task runner errors if
confirmpaymentstartedorconfirmpaymentreceivedmsgs are sent outside the proper context. Throw a FailedPreconditionException instead, to be translated into the proper gPRCStatusRuntimeExceptionbefore being sent to client.The important change is in
bisq.core.api.CoreTradesService:confirmpaymentreceivedmessage until after receiving aconfirmpaymentstartedmessage has been sent from the buyer.Also apitest send payment sent/rcvd precondition checks:
Based on 'master'.