Fix API editoffer bug: set fixed-price=0 on margin offers #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true in the payload. The API daemon editoffer's treatment of (fixed) price and isUsingMktPriceMargin flag in the API has been inconsistent with the UI. With this change: when isUsingMktPriceMargin=true, (fixed) price is set to 0 on the server. API clients, however, still must show the calculated price when isUsingMktPriceMargin=true, making this fix hard to test in the client. The server will now throw an exception if (fixed) price and isUsingMktPriceMargin flag in the API are not properly set in the API server. This fix is intended to prevent issues such as bisq-network#6170 from happening for this reason. The offer maker edited offers with API, creating inconsistent state described above. It is hoped the user's offers can be fixed by editing them in the UI. Based on `master`.
|
This PR remains a draft pending further testing. |
ghubstan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying to take offers having (fixed)
price!=0, andisUsingMktPriceMargin=true in the payload.The API daemon
editoffer'streatment of (fixed)priceandisUsingMktPriceMarginflag in the API has been inconsistent with the UI.With this change: when isUsingMktPriceMargin=true, (fixed) price is set to 0 on the server. API clients, however, still receive and must show the calculated
pricewhen isUsingMktPriceMargin=true, making this fix hard to test in the client. The server will now throw an exception if (fixed) price and isUsingMktPriceMargin flag in the API are not properly set in the API server.This fix is intended to prevent issues such as #6170 from happening for this reason. The offer maker edited offers with API, creating inconsistent state described above. It is hoped the user's offers can be fixed by editing them in the UI.
Based on
master.