Code

Release/v1.4.0 and v1.4.1#4655

Code

Merged

ripcurlx merged 143 commits intomasterbisq-network/bisq:masterfrom release/v1.4.0bisq-network/bisq:release/v1.4.0Copy head branch name to clipboardOct 20, 2020

+4,920-2,575

Commits

Commits on Oct 8, 2020

• Bump version number for v1.4.0

  ripcurlx

  committed
  5294820

• Update translations for v1.4.0

  ripcurlx

  committed
  2d06946

• Create a P2WPKH keychain for new btc wallets

  oscarguindzberg

  committed
  f13a7b1

• Add a P2WPKH keychain for existing wallets

  oscarguindzberg

  committed
  cd28660

• AddressEntry: Add boolean segwit flag

  oscarguindzberg

  committed
  ced357c

• Stop using LegacyAddress for btc addresses

  oscarguindzberg

  committed
  e85c66b

• Fix log msg in BtcCoinSelector

  oscarguindzberg

  committed
  0c7f345

• Comment out segwit BSQ account path

  Show description for 0f4c66f
  oscarguindzberg

  committed
  0f4c66f

• TradeWalletService: adapt to segwit wallet

  oscarguindzberg

  committed
  2551571

• WalletService: adapt to segwit wallet

  oscarguindzberg

  committed
  d8b7557

• New AddressEntry: use different script types

  Show description for a370848
  oscarguindzberg

  committed
  a370848

• AddressEntryList: arbitrator entry use P2PKH

  oscarguindzberg

  committed
  a9cc28f

• Add segwit/legacy checbox for address creation

  oscarguindzberg

  committed
  f9f5d92

• Serialize tx without segwit

  Show description for 1f3c585
  oscarguindzberg

  committed
  1f3c585

• Don't create an extra address at startup

  oscarguindzberg

  committed
  58afc00

• Don't create a wallet address when not needed

  oscarguindzberg

  committed
  e2f74f0

• Remove unused WalletService.findKeyFromPubKeyHash()

  oscarguindzberg

  committed
  d1aeedd

• Remove unused import

  oscarguindzberg

  committed
  78a2a43

• Enable reusing unused AVAILABLE entries

  oscarguindzberg

  committed
  01455d2

• Make codacy happy

  oscarguindzberg

  committed
  4a2c0ad

• Validate AddressEntry.segwit

  oscarguindzberg

  committed
  86ddd06

• Make it clear segwit is not used for the trade protocol yet.

  oscarguindzberg

  committed
  b9e404f

• BtcWalletService.getFreshAddressEntry(): code clean up

  oscarguindzberg

  committed
  5524ba3

• Construct dummy outputs with LegacyAddress

  oscarguindzberg

  committed
  d1aaf3e

• setWitness(): Code clean up

  oscarguindzberg

  committed
  3554e19

• Use try-with-resources

  oscarguindzberg

  committed
  499d7b7

• Improve error handling for P2WPKH

  oscarguindzberg

  committed
  1d82c01

• Switch back to LegacyAddress for fee estimation

  oscarguindzberg

  committed
  694446c

• Fix add segwit keychain for encrypted wallet

  oscarguindzberg

  committed
  a747e83

• Use bitcoinj 0.15.8 (commit a733034)

  oscarguindzberg

  committed
  417daf5

• Do a backup of the wallet before segwit migration

  oscarguindzberg

  committed
  87da2ae

• Check migratedWalletToSegwit is true

  oscarguindzberg

  committed
  261e0ec

• Merge pull request #4568 from oscarguindzberg/segwitWallet

  Show description for 35e0c34
  sqrrm

  authored
  35e0c34

• Add NO_ADDRESS_PRE_FIX capability.

  Show description for 9404e8f
  chimp1984

  committed
  9404e8f

• Cleanups

  Show description for e73a4b4
  chimp1984

  committed
  e73a4b4

• Make onRemoved default in interface

  chimp1984

  committed
  6f7dfcf

• Add methods for getting peers capabilities

  chimp1984

  committed
  40f9cfb

• Remove verification for address prefix

  Show description for 8aec306
  chimp1984

  committed
  8aec306

• Clear capabilitiesListeners at shutdown

  Show description for 9821dd6
  chimp1984

  committed
  9821dd6

• Refactor: move SupportedCapabilitiesMessage handling code out to a method

  Show description for 17974f3
  chimp1984

  committed
  17974f3

• Use only node address for equals and hashcode

  Show description for 1c07be0
  chimp1984

  committed
  1c07be0

• Pass supportedCapabilities to PeerManager. Not further processed yet, will be done in next commits

  Show description for bf659a1
  chimp1984

  committed
  bf659a1

• Use getSingleThreadListeningExecutor, cleanups

  chimp1984

  committed
  2523c2e

• Apply code inspection suggestions

  Show description for 765f9ea
  chimp1984

  committed
  765f9ea

• Add findPeersCapabilities method

  chimp1984

  committed
  186a9d6

• Add getDateAsLong method, add setter for capabilities

  chimp1984

  committed
  7af16d7

• Add findPeersCapabilities method

  Show description for 25bfe2d
  chimp1984

  committed
  25bfe2d

• Replace persistedPeers with peerList

  chimp1984

  committed
  2552675

• Use getPersistedPeers for peerList.getList() calls

  Show description for bf674ea
  chimp1984

  committed
  bf674ea

• Update common/src/main/java/bisq/common/app/Capability.java

  Show description for cf06930
  

  chimp1984

  and

  sqrrm

  committed
  cf06930

• Update p2p/src/main/java/bisq/network/p2p/network/Connection.java

  Show description for 983f610
  

  chimp1984

  and

  sqrrm

  committed
  983f610

• Fix incorrect handling of decryptedEntries size

  chimp1984

  committed
  31e7e26

• Refactor: Return early

  chimp1984

  committed
  4575516

• Refactor: Rearrange code, remove unused methods, renamings (no functional change)

  chimp1984

  committed
  ed960ab

• Refactor: Rename method

  chimp1984

  committed
  0686079

• Use connection.getPeersNodeAddressOptional().isPresent() instead of connection.hasPeersNodeAddress() which does the same internally

  chimp1984

  committed
  31ce5cc

• Fix tests

  chimp1984

  committed
  cfda0af

• Use a hashset instead of list to avoid duplicates. Filter out my own node from persisted peers.

  Show description for 351db88
  chimp1984

  committed
  351db88

• Decrease failedConnectionAttempts onConnection

  Show description for 2fd0104
  chimp1984

  committed
  2fd0104

• Fix incorrect collection used in == 1 check

  chimp1984

  committed
  f36a173

• Add isPresent check

  chimp1984

  committed
  b748bff

• Do not log size as we don't want to call potentially expensive toProtoMessage method

  chimp1984

  committed
  c7f23e8

• Copy peers in a new hashset to avoid concurrent modification exc at serialisation

  Show description for f53290b
  chimp1984

  committed
  f53290b

• Dont reassign param

  chimp1984

  committed
  447235c

• Use custom class MailboxItem instead of Tuple

  Show description for c88bc1c
  chimp1984

  committed
  c88bc1c

• Apply code review suggestions

  Show description for c8feef1
  chimp1984

  committed
  c8feef1

• When updating the capability from a reported peer we check if the reported one has higher capabilities, otherwise we ignore it.

  chimp1984

  committed
  4f685f8

• Apply codacy suggestions

  chimp1984

  committed
  6e3fdbc

• Add TradeStatistics3 and related classes

  Show description for 00bed02
  chimp1984

  committed
  00bed02

• Remove PublishTradeStatistics from buyer protocol

  Show description for 406bcfb
  chimp1984

  committed
  406bcfb

• Refactor: Move class

  chimp1984

  committed
  b75aa67

• Refactor: Rename class

  chimp1984

  committed
  a522d0a

• let seller publish trade statistics only if peer is updated user. If not the peer will publish only.

  chimp1984

  committed
  b2665bd

• Delete TradeStatistics (version 1)

  chimp1984

  committed
  6d43c09

• We "hack" TradeStatistics2StorageService to fulfill our needs:

  Show description for 9820751
  chimp1984

  committed
  9820751

• Apply TradeStatistics3 to TradeStatisticsManager and some related classes

  chimp1984

  committed
  c4a4c87

• Apply TradeStatistics3 to client classes

  chimp1984

  committed
  52be126

• Adjust tests, remove tests which do not make sense anymore

  chimp1984

  committed
  0e70a99

• Use TradeStatistics3 in protobuf file

  chimp1984

  committed
  6766835

• Remove resource file

  chimp1984

  committed
  b14266d

• Prune mediator and refund agent entries for all entries beside the last 100 we use for the selection algorithm.

  chimp1984

  committed
  9016cb6

• Add injector.getInstance(TradeStatisticsConverter.class) to BisqExecutable to enforce inclusion.

  Show description for f56fe42
  chimp1984

  committed
  f56fe42

• Do conversion in a thread to not block UI thread. takes about 4 seconds on my machine.

  Show description for fa374b9
  chimp1984

  committed
  fa374b9

• Add filter for excluding null objects

  chimp1984

  committed
  213050c

• Add check that size is > LOOK_BACK_RANGE

  chimp1984

  committed
  17f4ae2

• Add resource file for 1.4.0 (should be updated at release time)

  chimp1984

  committed
  e95ab2a

• Apply codacy suggestions

  Show description for 58d2f1b
  chimp1984

  committed
  58d2f1b

• Remove copy&past mistake

  chimp1984

  committed
  197d8c1

• Republish trade statistics from seller side if peer capability is know. This is not the case without getting PR #4609 merges as well.

  Show description for 18a27e9
  chimp1984

  committed
  18a27e9

• Remove comment line

  chimp1984

  committed
  68a10cf

Commits on Oct 9, 2020

• Remove unused variable

  chimp1984

  committed
  66740b7

• Cleanups: Remove outdated TODOs, fix typos

  chimp1984

  committed
  39c8ade

• Merge pull request #4610 from chimp1984/remove-address-prefix

  Show description for 352d954
  ripcurlx

  authored
  352d954

• Merge pull request #4611 from chimp1984/new-trade-statistics

  Show description for 3687a03
  ripcurlx

  authored
  3687a03

Commits on Oct 11, 2020

• Set memo to tx after tx creation and not on broadcast success, as broadcast success might not get called (even it is broadcast -> pending btcj bug)

  chimp1984

  committed
  4d2f1b5

• Only show xmr auto conf label for sell offers

  chimp1984

  committed
  db10aa3

• Use hash at conversion also for local data to avoid duplicates.

  chimp1984

  committed
  1f0590d

• Use aesKey in Wallet.toString()

  oscarguindzberg

  committed
  8e93e4b

Commits on Oct 12, 2020

• Merge pull request #4627 from oscarguindzberg/fixWalletToString

  Show description for 2dc7662
  ripcurlx

  authored
  2dc7662

• Merge pull request #4626 from chimp1984/avoid-duplicate-trade-stats

  Show description for 1eb730a
  ripcurlx

  authored
  1eb730a

• Merge pull request #4625 from chimp1984/only-showXmrAutoConf-for-sell-offers

  Show description for ee14884
  ripcurlx

  authored
  ee14884

• Merge pull request #4619 from chimp1984/fix-memo-bug-issue-4616

  Show description for 41b2e6a
  ripcurlx

  authored
  41b2e6a

• Stop PeerGroup only if running

  oscarguindzberg

  committed
  1c0655e

Commits on Oct 13, 2020

• Change write json files to disk strategy

  Show description for 0d46906
  chimp1984

  committed
  0d46906

• Merge pull request #4635 from chimp1984/fix-performance-issues-at-dump-dao-data

  Show description for 88f9eee
  ripcurlx

  authored
  88f9eee

• Merge pull request #4631 from oscarguindzberg/fixPeerGroupStop

  Show description for e5dd316
  ripcurlx

  authored
  e5dd316

• Fix bug at mediation with old client

  Show description for 3b4d109
  chimp1984

  committed
  3b4d109

• Merge pull request #4638 from chimp1984/fix-mediation-bug

  Show description for 129eaa7
  sqrrm

  authored
  129eaa7

• Exclude depositTxId as it seems that leads to

  Show description for b719302
  chimp1984

  committed
  b719302

• Update resource file.

  Show description for 30c77aa
  chimp1984

  committed
  30c77aa

• Merge pull request #4640 from chimp1984/update-trade-stat-resource-file

  Show description for be08c86
  sqrrm

  authored
  be08c86

• Accept segwit addresses when sending non-BSQ funds

  oscarguindzberg

  committed
  8647007

• Merge pull request #4632 from oscarguindzberg/fixSendNonBsq

  Show description for e30a7e0
  ripcurlx

  authored
  e30a7e0

Commits on Oct 14, 2020

• Change data response behaviour

  Show description for cc5bdfa
  chimp1984

  committed
  cc5bdfa

• Remove lombok getter for date and rename getDate to getDateAsLong and getTradeDate to getDate.

  chimp1984

  committed
  b0bc3d0

• Add GetInventory messages

  Show description for 5f9d3d1
  chimp1984

  committed
  5f9d3d1

• Improve GetInventoryRequester and GetInventoryRequestManager

  chimp1984

  committed
  32b953b

• Merge pull request #4642 from chimp1984/change-handling-of-trade-stats-in-data-response

  Show description for 8ed83ca
  sqrrm

  authored
  8ed83ca

• Merge pull request #4643 from chimp1984/add-get-inventory-msg

  Show description for c41bfd7
  sqrrm

  authored
  c41bfd7

• Replace emzy's v2 seednodes with new v3 seednodes

  

  wiz

  authored and

  ripcurlx

  committed
  866b227

• Resolve conflict in 'core/src/main/resources/btc_mainnet.seednodes'.

  

  mrosseel

  authored and

  ripcurlx

  committed
  58f5066

• Use toString for NullPointerException

  chimp1984

  committed
  feb4e52

• Add dont show again check box to validation exception popups

  chimp1984

  committed
  fc87524

• Dont include dead transactions in check for unconfirmed txs chain

  chimp1984

  committed
  fe3828e

Commits on Oct 15, 2020

• Exclude time-locked txs at isUnconfirmedTransactionsLimitHit

  Show description for 8b404e1
  chimp1984

  committed
  8b404e1

• Merge pull request #4647 from chimp1984/persist-seen-mediator-warnings

  Show description for 9946496
  ripcurlx

  authored
  9946496

• Merge pull request #4648 from chimp1984/dont-include-dead-txs-in-limit-check

  Show description for 4f26544
  ripcurlx

  authored
  4f26544

• Update bitcoinj checkpoints for v1.4.0

  ripcurlx

  committed
  b7c6c42

• Only remove offer locally when necessary

  ripcurlx

  committed
  c08a9bd

• Merge pull request #4651 from ripcurlx/keep-offer-when-canceling

  Show description for 101c172
  sqrrm

  authored
  101c172

• Update data stores for v1.4.0

  ripcurlx

  committed
  4e2e523

• Revert jdk.module.illegalAccess=deny

  Show description for 10b05aa
  ripcurlx

  committed
  10b05aa

Commits on Oct 16, 2020

• Revert to SNAPSHOT version

  ripcurlx

  committed
  bac1e7b

• Move segwit checkbox

  oscarguindzberg

  committed
  3e17058

• Handle Capabilities for encrypted messages (offer availibility request/response)

  Show description for 6b4d77f
  chimp1984

  committed
  6b4d77f

• Add file name to temp file at write to disk

  chimp1984

  committed
  0b38fcc

• Fix min height for trade statistics table

  chimp1984

  committed
  8cb6a05

• Republish trade statistics if not found in existing trade stats.

  Show description for 294b45d
  chimp1984

  committed
  294b45d

• Merge pull request #4659 from chimp1984/fix-missing-capability-handling-for-encrypted-msg

  Show description for b924107
  sqrrm

  authored
  b924107

• Merge pull request #4662 from chimp1984/fix-republish-trade-stats

  Show description for 0dea954
  sqrrm

  authored
  0dea954

Commits on Oct 17, 2020

• Merge pull request #4658 from oscarguindzberg/moveSegwitCheckbox

  Show description for b5d16bc
  ripcurlx

  authored
  b5d16bc

Commits on Oct 18, 2020

• Bump version number for v1.4.1

  ripcurlx

  committed
  7ae6e84

Commits on Oct 19, 2020

• Revert to SNAPSHOT version

  ripcurlx

  committed
  b1fb571