Only remove offer locally when necessary #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just did a quick test on regtest. The error has now gone upon cancelling on the first step and cancelling immediately on the second step. However, if the taker goes on to fund the trade from their Bisq wallet and then cancels, the error appears again after dismissing the two warning dialog boxes about having already funded the offer. I think one or more of the remaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @stejbac findings an offer shouldn't be removed locally when the trade is cancelled before any fees were paid.
Currently this causes following warning messages when cancelling the taking of an offer.