Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont include dead transactions in check for unconfirmed txs chain #4648

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Dont include dead transactions in check for unconfirmed txs chain #4648

merged 2 commits into from
Oct 15, 2020

Conversation

chimp1984
Copy link
Contributor

No description provided.

@chimp1984
Dont include dead transactions in check for unconfirmed txs chain
fe3828e
@chimp1984
Exclude time-locked txs at isUnconfirmedTransactionsLimitHit
8b404e1 
For published delayed payout transactions we do not receive the tx confidence
so we cannot check if it is confirmed so we ignore it for that check. The check is any arbitrarily
using a limit of 20, so we don't need to be exact here. Should just reduce the likelihood of issues with
the too long chains of unconfirmed transactions.
ripcurlx
ripcurlx approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Fixes my issue of loitering past delayed deposit transactions blocking me to take an offer. Could be the case that this is caused of my "broken" Regtest account, but better to include this for heavy traders, who might run into similar issues.

@ripcurlx ripcurlx merged commit 4f26544 into bisq-network:release/v1.4.0 Oct 15, 2020
@chimp1984 chimp1984 deleted the dont-include-dead-txs-in-limit-check branch October 17, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimp1984 @ripcurlx