Add GetInventory messages #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used for monitoring seed nodes. Instead of requesting all data (we cannot request all in fact as it is too large) we request the number of items the node has. This code will not have any impact atm. It will be triggered once a new monitor module gets added which will send the GetInventoryRequest to the seeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used for monitoring seed nodes.
Instead of requesting all data (we cannot request all in fact as it is too large)
we request the number of items the node has.
This code will not have any impact atm. It will be triggered once a new monitor module gets added which
will send the GetInventoryRequest to the seeds.
It would be nice to get it into 1.4.0 as then we have it already deployed for the seed nodes. Otherwise they will need to update in a few days again once the new monitor is running. The new monitor project will be a PR to master and coming soon as well :-)
Update: Here is the light weight monitor: https://github.com/chimp1984/bisq/tree/add-InventoryMonitor-module
Will wait with making a PR until I can test it with seeds once that PR is merged.