Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmats for osx-arm64 #52195

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

EricKutschera
Copy link
Contributor

  • Remove build_failure.osx-64.yaml
  • Increment build number

In response to Xinglab/rmats-turbo#395


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

* Remove build_failure.osx-64.yaml
* Increment build number
Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request involves two primary changes: the deletion of the build_failure.osx-64.yaml file and updates to the meta.yaml file for the rmats package version 4.3.0. The deleted build_failure.osx-64.yaml file contained metadata and logs related to a previous failed build of the BamTools recipe, including a SHA hash and a log of the build process. This file served as a diagnostic record for build issues. In the meta.yaml file, the build number was incremented from 3 to 4, and the list of additional platforms was updated to include osx-arm64, expanding the package's compatibility. Additionally, a patch file rmats_pipeline_setup.patch was added to the source section, and the dependency on gsl was updated to remove the version specification while adding setuptools as a new dependency. No changes were made to other sections such as source URL, test commands, or other metadata.

Possibly related PRs

  • Pin gsl to 2.5 for rmats #51411: The changes in this PR involve updating the gsl dependency in the meta.yaml file for the rmats package, which is directly related to the main PR that also modifies the meta.yaml for the rmats package.
  • longreadsum: add aarch64/arm64 builds #51121: This PR adds support for osx-arm64 builds in the longreadsum package, which is relevant as the main PR also discusses changes related to build configurations and platform support.
  • mashmap: add aarch64 build #51161: This PR adds support for osx-arm64 builds in the mashmap package, which is relevant as the main PR also discusses changes related to build configurations and platform support.
  • updated revision and enabled osx build #51176: This PR updates the pgrc package to enable builds on osx-arm64, which is relevant to the main PR's changes regarding platform support.
  • r-cobrar: add aarch64/arm64 builds #51203: This PR adds support for osx-arm64 builds in the r-cobrar package, which is related to the main PR's focus on platform compatibility.
  • pepnovo: add aarch64/arm64 build #51206: This PR adds support for osx-arm64 builds in the pepnovo package, which is relevant to the main PR's changes regarding architecture support.
  • Sentieon add ARM support #51837: This PR adds support for osx-arm64 builds in the sentieon package, which is relevant to the main PR's focus on platform compatibility.
  • mutyper: add aarch64/arm64 builds #51905: This PR introduces builds for osx-arm64 architecture in the mutyper package, which aligns with the main PR's focus on architecture compatibility.
  • bayestyper: add arm64/aarch64 builds #52076: This PR adds support for arm64/aarch64 builds in the bayestyper package, which is relevant to the main PR's changes regarding architecture support.
  • Add osx-arm64 to r-facets #52091: This PR adds support for osx-arm64 in the r-facets and r-spp packages, which is relevant to the main PR's focus on platform compatibility.
  • Add osx-arm64 to agc #52180: This PR adds support for osx-arm64 in the agc package, which is relevant to the main PR's changes regarding platform support.
  • Racon: add arm64 build #52209: This PR adds support for arm64 builds in the racon package, which is relevant to the main PR's focus on architecture compatibility.

Suggested labels

please review & merge, osx-arm64

Suggested reviewers

  • martin-g

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5982947 and 5c685be.

📒 Files selected for processing (1)
  • recipes/rmats/meta.yaml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/rmats/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

* Unpin gsl
  + WARNING: failed to get package records, retrying.  exception was: Unsatisfiable dependencies for platform osx-arm64: {MatchSpec("gsl=2.5")}
* Use setuptools instead of distutils
  + rMATS_pipeline/setup.py:2: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  + ModuleNotFoundError: No module named 'distutils'
* STAR is only needed by rmats when starting with fastq files
* WARNING: failed to get package records, retrying.  exception was: Unsatisfiable dependencies for platform osx-arm64: {MatchSpec("star[version='>=2.5']")}
  + STAR --version [...]run_test.sh: line 7: [...]/bin/STAR: Bad CPU type in executable
@EricKutschera
Copy link
Contributor Author

The osx-64 build failure was due to distutils being removed in python 3.12. I added a patch to use setuptools instead. For osx-arm64 I removed the STAR dependency. It's really an optional dependency for rmats since rmats can be run starting with bam files. It looks like there was an attempt add osx-arm64 for STAR but it doesn't seem to be easy to get that working: #50348

@EricKutschera
Copy link
Contributor Author

I removed the gsl=2.5 pin since osx-arm64 only seems to have 2.6 and 2.7 available: https://anaconda.org/conda-forge/gsl/files
This undoes the change from #51411
@npavlovikj what was the reason for restricting to gsl=2.5? Was it related to conda-forge gsl-2.7 using libgsl.so.25: Xinglab/rmats-turbo#352

@bgruening bgruening merged commit 05beeb4 into bioconda:master Nov 21, 2024
6 checks passed
@EricKutschera EricKutschera deleted the update-rmats-osx branch November 21, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants