Sentieon add ARM support #51837
Sentieon add ARM support #51837
Conversation
Add ARM support to Sentieon recipe.
|
Warning Rate limit exceeded@bgruening has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 30 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/sentieon/meta.yaml (2)
7-11: Consider improving patch documentation.While the patch is properly referenced, the comment "Fix driver scripts so they resolves location including symlinks" could be more descriptive about the specific issue it addresses and its importance.
Consider expanding the comment to explain:
- What specific driver scripts are affected
- Why symlink resolution is important
- Any potential issues this patch prevents
Line range hint
15-15: Fix build configuration for ARM support.There's a conflict between the build configuration and the intended ARM support:
- Line 15 skips builds on non-linux64 platforms (
skip: True # [not linux64])- Lines 44-46 add ARM platform support
- This configuration will prevent the package from building on ARM platforms despite being listed as supported
To properly enable ARM support, modify the build skip condition. Consider:
- skip: True # [not linux64] + skip: True # [not (linux64 or linux-aarch64 or osx-arm64)]Also applies to: 44-46
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/sentieon/meta.yaml(2 hunks)
🔇 Additional comments (1)
recipes/sentieon/meta.yaml (1)
Line range hint 17-18: LGTM: Proper dependency version handling.
The run_exports configuration with max_pin='x' follows best practices for preventing API/ABI breakage by ensuring compatible version constraints for downstream dependencies.
|
Sooo none of the tests actually run the binary. For ARM, we need to use |
Add ARM support to Sentieon recipe.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.