-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reseek #51882
Add Reseek #51882
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
recipes/reseek/build.sh
(1 hunks)recipes/reseek/meta.yaml
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- recipes/reseek/build.sh
🧰 Additional context used
🪛 yamllint
recipes/reseek/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (3)
recipes/reseek/meta.yaml (3)
19-24
:
Add OpenMP runtime dependencies.
The package requires OpenMP support, but the runtime dependencies are missing. This was previously flagged in earlier reviews and needs to be addressed.
Apply this diff:
requirements:
build:
- {{ compiler("cxx") }}
- {{ compiler("c") }}
- make
+ - llvm-openmp # [osx]
+ run:
+ - llvm-openmp # [osx]
+ - libgomp # [linux]
32-32
:
Add maintainer and platform information.
The recipe is missing the extra
section with maintainer information and additional platform support, which is required for Bioconda packages.
Add after the about section:
extra:
recipe-maintainers:
- apcamargo
additional-platforms:
- linux-aarch64
- osx-arm64
20-22
:
Configure GCC compiler for builds.
As mentioned in previous reviews, reseek requires GCC for compilation. The compiler configuration needs to be explicitly set.
Create a new file conda_build_config.yaml
with:
c_compiler_version: # [osx]
- 12 # [osx]
cxx_compiler_version: # [osx]
- 12 # [osx]
c_compiler: # [osx]
- gcc # [osx]
cxx_compiler: # [osx]
- gxx # [osx]
@BiocondaBot please add label |
@@ -0,0 +1,225 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this coming from? Maybe add a comment here, that this file needs to be kept in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the author's own script. In his repository he downloads it at build time, but I decided to have it within the recipe to have more control over it. I'll add a comment.
Thanks, @bgruening
I tried several approaches to use a newer version of Clang, but they failed. The author of the package compiles it for macOS using GCC, but this is not an option for us (as far as I know). Is there a solution that I'm missing? |
This PR adds
reseek
.Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.