Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new param in FeatureSettings menu + toggle ACK in Terminal menu… #1563

Merged
merged 15 commits into from
Jan 30, 2021

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented Jan 25, 2021

NEW FEATURES:

  1. Added in FeatureSettings menu the enumerated parameters defined in config.ini such as:
  • enabled, disabled
  • enabled, disabled, auto
  • etc...
    The purpose of this addition is to allow to set some settings without the need to use so frequently the config.ini.
  1. Added in Terminal menu a button to toggles the terminal ACK. The changed value is not made permanent on flash (it's meant just as a temporary setting change) . This means that in order to make the change permanent on falsh the usual FeatureSettings menu has to be used
  2. Added "MBL offset" parameter in ParameterSettings menu (MBL offset is already managed on Babystep menu)
  3. Rearranged all the language files grouping all the entries based on:
  • config.ini parameter / feature settings
  • machine paramater settings
  • standard parameter values (e.g. ON, OFF etc... used in many menus)
  • navigation buttons
  • action buttons
  • etc...
    The purpose of the changes is to better reuse (when possible) the existing labels instead of defining new ones (often) with an already existing meaning or to put in the proper group new entries (e.g. feature parameter, machine parameter, menus etc...).

resolve #1504 (partially): custom (requiring to edit the value) paramter settings could be added in the future
resolve #1298

PR STATUS: ready to be merged

@ETE-Design
Copy link

@digant73 Sorry to highjack this PR... Could you mabye also make an G26 Menu / Tool?

@sarvenn
Copy link

sarvenn commented Jan 29, 2021

Is this merged with master fw? Can I install the pre-compiled fw or compile my own using platform.ini file ?

@digant73 digant73 mentioned this pull request Jan 29, 2021
@oldman4U
Copy link
Contributor

sarvenn, you can click on the repo and download it from there.
Screenshot 2021-01-29 at 20 03 20

@Guilouz
Copy link
Contributor

Guilouz commented Jan 30, 2021

Mistake in your language_keywords.h, missing ":" for this strings :

#define LANG_KEY_CONFIRM "label_confirm:" //Confirm Sign
#define LANG_KEY_CANCEL "label_cancel:" //Cancel Sign
#define LANG_KEY_WARNING "label_warning:" //Exclamation Sign
#define LANG_KEY_INFO "label_info:" //Info Sign
#define LANG_KEY_POWER_FAILED "label_power_failed:" //Question Sign

@bigtreetech
Copy link
Owner

Mistake in your language_keywords.h, missing ":" for this strings :

#define LANG_KEY_CONFIRM "label_confirm:" //Confirm Sign
#define LANG_KEY_CANCEL "label_cancel:" //Cancel Sign
#define LANG_KEY_WARNING "label_warning:" //Exclamation Sign
#define LANG_KEY_INFO "label_info:" //Info Sign
#define LANG_KEY_POWER_FAILED "label_power_failed:" //Question Sign

fixed now, thank you

@bigtreetech bigtreetech merged commit 0ef0c63 into bigtreetech:master Jan 30, 2021
@digant73
Copy link
Contributor Author

@Guilouz, @bigtreetech Thanks for the double check and the fix. Although I see now that those keywords were already wrong at the origin (in the main branch)

Uz45 added a commit to Uz45/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jan 31, 2021
adds keyboard layout for quertz awerty bigtreetech#1550
Correction CZ translation bigtreetech#1546
FIX bigtreetech#1539 bigtreetech#1541
Fix get filesize and cancle print for RepRapFirmware bigtreetech#1533
This PR is fixing the bugs introduced by merging PR bigtreetech#1487 bigtreetech#1526
update german translation and add missing icons bigtreetech#1525
Add missing icons and Hungarian language bigtreetech#1520
Added Home Offset menu + bugfixes and cleanup bigtreetech#1518
Readme.md update and format fix bigtreetech#1557
Reduce global variables and cleanup bigtreetech#1558
Added the possibility to change to time the bootscreen logo is shown bigtreetech#1560
Beep when temp reached bigtreetech#1561
Added new param in FeatureSettings menu + toggle ACK in Terminal menu… bigtreetech#1563
@bigtreetech
Copy link
Owner

@digant73 Hello, Thank you very much for your help in the project. Do you have Facebook to communicate with? If it is not convenient to publish, you can send your contact information to our email “[email protected]

@digant73 digant73 deleted the bugfix-2021-01-25 branch May 31, 2021 14:12
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Access to Smart Filament Detection settings in screen settings [FR] the button terminalACK
8 participants