Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] the button terminalACK #1298

Closed
radek8 opened this issue Nov 27, 2020 · 8 comments · Fixed by #1563
Closed

[FR] the button terminalACK #1298

radek8 opened this issue Nov 27, 2020 · 8 comments · Fixed by #1563
Labels
enhancement New feature or request

Comments

@radek8
Copy link
Contributor

radek8 commented Nov 27, 2020

@digant73 your modification of the menuTerminal is great.
Could it be further improved with a button that would turn "terminalACK" on and off directly from the terminal environment?
Thank you
@radek8 radek8 added the enhancement New feature or request label Nov 27, 2020
@kisslorand
Copy link
Contributor

What would be the benefit of it?

@radek8
Copy link
Contributor Author

radek8 commented Nov 29, 2020

Directly in the terminal window I can turn on and off the communication of the display with the printer without having to go to the menu of printer parameters

@oldman4U
Copy link
Contributor

oldman4U commented Dec 2, 2020

Should we add this to the FR list?

@radek8
Copy link
Contributor Author

radek8 commented Dec 2, 2020

If no one else wants it, you don't have to.
It's not that important.

@oldman4U
Copy link
Contributor

oldman4U commented Dec 2, 2020

YOU want it and you do a lot for this project. So I add it and hopefully it will be available one day. 👍🏻

@radek8
Copy link
Contributor Author

radek8 commented Dec 2, 2020

:-)

@oldman4U oldman4U mentioned this issue Dec 2, 2020
Closed
@radek8 radek8 closed this as completed Dec 2, 2020
@digant73 digant73 mentioned this issue Jan 25, 2021
Merged
@oldman4U
Copy link
Contributor

Thank you @digant73

Please check PR #1563

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@radek8 @kisslorand @oldman4U