This PR is fixing the bugs introduced by merging PR #1487 #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with original
Sync 16.XII.2020
Sync 2020.XII.19
Sync 24.XII.2020
…ouchScreenFirmware # Conflicts: # TFT/src/User/API/SpeedControl.c
Sync 31.XII.2020
|
@AntoszHUN |
You shouldn't always vary with it. Then there would be no problem. Why wasn't it as good as it was? Now what should I look at? |
|
I watched. Will be good. I'll test it and see if it gets into the master. |
|
Thank you. |
|
@bigtreetech |
Uz45
added a commit
to Uz45/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Jan 25, 2021
adds keyboard layout for quertz awerty bigtreetech#1550 Correction CZ translation bigtreetech#1546 FIX bigtreetech#1539 bigtreetech#1541 Fix get filesize and cancle print for RepRapFirmware bigtreetech#1533 This PR is fixing the bugs introduced by merging PR bigtreetech#1487 bigtreetech#1526 update german translation and add missing icons bigtreetech#1525 Add missing icons and Hungarian language bigtreetech#1520 Added Home Offset menu + bugfixes and cleanup bigtreetech#1518
Uz45
added a commit
to Uz45/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Jan 31, 2021
adds keyboard layout for quertz awerty bigtreetech#1550 Correction CZ translation bigtreetech#1546 FIX bigtreetech#1539 bigtreetech#1541 Fix get filesize and cancle print for RepRapFirmware bigtreetech#1533 This PR is fixing the bugs introduced by merging PR bigtreetech#1487 bigtreetech#1526 update german translation and add missing icons bigtreetech#1525 Add missing icons and Hungarian language bigtreetech#1520 Added Home Offset menu + bugfixes and cleanup bigtreetech#1518 Readme.md update and format fix bigtreetech#1557 Reduce global variables and cleanup bigtreetech#1558 Added the possibility to change to time the bootscreen logo is shown bigtreetech#1560 Beep when temp reached bigtreetech#1561 Added new param in FeatureSettings menu + toggle ACK in Terminal menu… bigtreetech#1563
jeffeb3
pushed a commit
to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
MKS or BTT TFT
Description
This is a bugfix for the bugs introduced by PR #1487.
The fixed bugs are:
filament length not calculated when printing from remote host and from onboard SD
in some cases, prinintg from remote host and onboard SD, the file name is missing from the print summary
other languages than English are not taken into account properly after print finished
in some cases, printing from remote host from onboard SD, after print finished cannot exit from the menu, screen freezes
Freeze.mp4
infoFile.source == BOARD_SD_REMOTE). This PR makes the TFT aware again if print was started from remote host or not.Benefits
Everyone
Additional info
This PR does not include any extra popup, there's not user configurable parameter added.
Extra RAM usage: 0 (zero)
Extra flash usage: ~72 bytes