Fix get filesize and cancle print for RepRapFirmware #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemet Print from SD-Crd for RepRapFirmware
The displa will autodetect witch Firmware is use on the conected bord
request_M23_M36 use the wron word to find the filesize and RepRapFirmware nor supportetd M524 it used M1
Change M1 to M0
Uz45
added a commit
to Uz45/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Jan 25, 2021
adds keyboard layout for quertz awerty bigtreetech#1550 Correction CZ translation bigtreetech#1546 FIX bigtreetech#1539 bigtreetech#1541 Fix get filesize and cancle print for RepRapFirmware bigtreetech#1533 This PR is fixing the bugs introduced by merging PR bigtreetech#1487 bigtreetech#1526 update german translation and add missing icons bigtreetech#1525 Add missing icons and Hungarian language bigtreetech#1520 Added Home Offset menu + bugfixes and cleanup bigtreetech#1518
Uz45
added a commit
to Uz45/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Jan 31, 2021
adds keyboard layout for quertz awerty bigtreetech#1550 Correction CZ translation bigtreetech#1546 FIX bigtreetech#1539 bigtreetech#1541 Fix get filesize and cancle print for RepRapFirmware bigtreetech#1533 This PR is fixing the bugs introduced by merging PR bigtreetech#1487 bigtreetech#1526 update german translation and add missing icons bigtreetech#1525 Add missing icons and Hungarian language bigtreetech#1520 Added Home Offset menu + bugfixes and cleanup bigtreetech#1518 Readme.md update and format fix bigtreetech#1557 Reduce global variables and cleanup bigtreetech#1558 Added the possibility to change to time the bootscreen logo is shown bigtreetech#1560 Beep when temp reached bigtreetech#1561 Added new param in FeatureSettings menu + toggle ACK in Terminal menu… bigtreetech#1563
Uz45
added a commit
to Uz45/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Feb 2, 2021
…etech#1584 This PR fixes a bug introduced in PR bigtreetech#1533 @Thro42 request_M0() is not exported in gcode.h so the compiler can't find the function in Printing.c which results in a function call of an empty function.
jeffeb3
pushed a commit
to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description
the function request_M23_M36 has problems to read the file size in RepRapFirmware. It has to serch for 'size":' not 'Size:' .
Also I fixt a problem by canle a print. M524 is not supportet in reprap firmware it has to use M0
Benefits
Better functionality in RepRapFirmware
Related Issues
#1400