-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event LEDs mode, pragma once, PID knob_led interaction, preheatdone sound, small fixes and cleanup #1209
event LEDs mode, pragma once, PID knob_led interaction, preheatdone sound, small fixes and cleanup #1209
Conversation
The way languages are set is changed. Made a new branch for it
* added sequential mode to languages * Added seguential mode to config * Added encoder led wakeup in wakeup LCD Bugs to check * feature settings doens't keep it's settings
Still the odd behavior that the settings from the ini file gets corrupted when rebootig
Need a better name for it instead of 'setSequentialModeColor' Maybe something like: sequentialModeWorker
Try to set PARA_SIZE to 768 in flashStore.h and see if you solve the problem |
@digant73 Thank you. Didn't think about that option. Was checking my own code thinking I messed up somewhere. I'll try this when I'm working on it. Edit: Did try it out (had to wait before I could go to bed) |
I'm glad you're working towards getting #define PRINTER_EVENT_LEDS implemented. It should work as indicated by Marlin in Configuration.h (below). While performing a PID tuning, I think the LEDs should change to different colors like a rainbow, then Green. Considering there is an OFF button in the LED Color section, maybe there should be an AUTO button as well, which would default back to Printer Event LEDs if OFF or one of the other colors are selected.
|
Printer Event LEDs
Yes. This is implemented. Maybe is should change the name. I thought they called it sequential mode... |
Which TFT did you use to test? |
@stellarspace not yet, but I'm using a tft35 e3 @bigtreetech this fr is not ready yet (and not completely tested and it's having a bug (as mentioned in the text)) |
So the only thing you need to implement is the color when PID Tuning, and to find the error? Would like to try it out, could you pls. merge newest master? |
I would like to advocate for the use of curly braces in 'if' statements, even when it's only one line. There has already been a bug due to missing curly braces, and I can see this happening again. Otherwise, it should have curly braces:
Is there a coding guideline somewhere for this repo? |
LEDs don’t even show when idle or printing. You can only change the color of the LED to RGBW. This would change that. You can use GitHub Desktop to Merge master with p1209, then resolve the conflicts in Visual Studio Code and build the TFT firmware of your choosing.
Coding guideline? No, this repository is poorly maintained in my opinion and there aren’t that many developers. |
I just do it like everyone else does. And by the way. There is nothing wrong with no curly brackets. When you add an extra line you should add them... I also changed some other parts to this. By the way, it's pretty common, even within projects from big companies, to don't use them when there is just one row. |
I'll merge it when I have time.. |
Fair enough, there are coding styles that encourage not to use them when not needed. I've been following the Microsoft guidelines so I may be a bit biased. Apple's infamous "goto fail" SSL security flaw was a result of not having curly braces so personally I prefer having them. In the grand scheme of things, I'd like to see consistency and would love to see a coding style guideline adopted (Microsoft, Google, LLVM, etc). |
I agree. The nice thing about visual studio is that it can already do a lot of the styling work for you.
Only problem is that there will be a lot of changes in the repo...
I agree it's better to use curly braces.
It also possbile to go from none curly to curly to the files i'm changing/ cleaning instead of removing them..
Met vriendelijke groet;
Peter van Weeterloo
…________________________________
Van: Makoto Schoppert <[email protected]>
Verzonden: vrijdag 30 oktober 2020 16:57
Aan: bigtreetech/BIGTREETECH-TouchScreenFirmware <[email protected]>
CC: Peter van Weeterloo <[email protected]>; Author <[email protected]>
Onderwerp: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] sequential mode whileprint (help needed with feature issues. See 'why is this a draft') (#1209)
I would like to advocate for the use of curly braces in 'if' statements, even when it's only one line. There has already been a bug due to missing curly braces, and I can see this happening again.
I would say the only exception would be if the statement is on the same line as the if statement, like this:
if (x == y) doThis();
Otherwise, it should have curly braces:
if (x == y)
{
if (x != z)
{
doThis();
}
}
Is there a coding guideline somewhere for this repo?
I just do it like everyone else does. And by the way. There is nothing wrong with no curly brackets. When you add an extra line you should add them...
I also changed some other parts to this. By the way, it's pretty common, even within projects from big companies, to don't use them when there is just one row.
Fair enough, there are coding styles that encourage not to use them when not needed. I've been following the Microsoft guidelines<https://github.com/microsoft/WinObjC/wiki/Coding-Standards#223----always-use-braces-around-bodies> so I may be a bit biased. Apple's infamous "goto fail" SSL security flaw was a result of not having curly braces so personally I prefer having them.
In the grand scheme of things, I'd like to see consistency and would love to see a coding style guideline adopted (Microsoft, Google, LLVM, etc).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2VWALIJ7HQUZXXEZ2E243SNLO7LANCNFSM4S7Z354Q>.
|
I fixed the conflicts, but the LEDs aren't working, the Fan does go from F0 to CtL upon reboot and the Feature menu is non-functional. Not sure if I fixed the conflicts correctly. I'm new to GitHub Desktop working in tandem with Visual Studio Code. |
@guruathwal do you have any idea of the problem mentioned in the main post? I can't find a solution for it :( |
@traffic-light I will look into it. I need some time. |
Thank you! Take your time. No hurries! (Still need to do some fine-tuning in the neopixel code I added. But first I want that the error is gone....) |
@bigtreetech Could you mabye look at this, and make the last changes to make it work and merge it? |
@traffic-light it seems the PR is abandoned. Do you think it can be resumed by someone else and merged in BTT main branch? If so, what's remaining to be fixed in the LED handling? |
Hi digant73. I believe it would make sense to start with a new PR. Beep once preheating has finished is done, so the main new stuff would be the LED color and pragma_once. This PR has been made before BTT added support for "external" Neopixel, not sure how this affects the functionality. I love, that the external led's turn off once the screen dims, something you probably want to avoid during preheating. oldman |
yes I know. from this old PR only EVENT LED and the use of #pragma can be resumed. I will start with the EVENT LED first. We will see how to handle the external Neopixel controlled by the LCD's knob LED |
👍🏻 Let me know in case I can help with testing. |
I can't log in. So Ill try it this way:
I didn't have much time too fix my printer and I need to fix my printer before I can test my software.
Besides that I've got to fix my print I've to restart my programm because of all the changes already made (and the features that are not needed anymore...)
Outlook voor Android<https://aka.ms/AAb9ysg> downloaden
…________________________________
From: Antonino Di Guardo ***@***.***>
Sent: Wednesday, August 4, 2021 12:45:19 PM
To: bigtreetech/BIGTREETECH-TouchScreenFirmware ***@***.***>
Cc: Peter van Weeterloo ***@***.***>; Mention ***@***.***>
Subject: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] event LEDs mode, pragma once, PID knob_led interaction, preheatdone sound, small fixes and cleanup (#1209)
yes I know. from this old PR only EVENT LED and the use of #pragma can be resumed. I will start with the EVENT LED first. We will see how to handle the external Neopixel controlled by the LCD's knob LED
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2VWAM6V2GN33QPMC7Z363T3EK37ANCNFSM4S7Z354Q>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
Peter is back!!! 🤩 |
So if I get it right, this PR to be replaced by a new "updated" one? Would be happy to help in it. @oldman4U @traffic-light @digant73 |
Seems so. Yes!😁 |
Until 19 august I don't have that much spare time due to a resit of a exam. (Failed the previous one :( )
Maybe after august I can take a look at it and test it on my somewhat working 3d printer
Outlook voor Android<https://aka.ms/AAb9ysg> downloaden
…________________________________
From: MarkusThur ***@***.***>
Sent: Thursday, August 5, 2021 9:35:34 AM
To: bigtreetech/BIGTREETECH-TouchScreenFirmware ***@***.***>
Cc: Peter van Weeterloo ***@***.***>; Mention ***@***.***>
Subject: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] event LEDs mode, pragma once, PID knob_led interaction, preheatdone sound, small fixes and cleanup (#1209)
So if I get it right, this PR to be replaced by a new "updated" one? Would be happy to help in it. @oldman4U<https://github.com/oldman4U> @traffic-light<https://github.com/traffic-light> @digant73<https://github.com/digant73>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2VWAK6CU34S5BGUHCWTKDT3I5MNANCNFSM4S7Z354Q>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
@traffic-light if it's ok for you (just to integrate the first version) I can port your code in the current BTT main branch. In the meanwhile users will start to provide their feedbacks. Obviously all credits to ypur work. |
I'll take a look at it next week. I'll create a new PR for it
|
traffic-light. Whats about your exam? Success!!?? |
Hope you managed to get your exams passed. Still running your code from way back and Its still going good. I moved the tft35 control over to full control by Octoprint and never looked back. the machine is semi retired as I got a 2nd hand Ender 5 and upgraded it to the max with a new larger frame and build area powered with an mks sgen-l v1 also controlled by Octoprint as neopixel support was worse than btt.. Good luck boss |
I need to restart my work due to much changes. It takes some time to get into the firmware again -_-'
Met vriendelijke groet;
Peter van Weeterloo
…________________________________
Van: ETE-Design ***@***.***>
Verzonden: woensdag 22 september 2021 00:11
Aan: bigtreetech/BIGTREETECH-TouchScreenFirmware ***@***.***>
CC: Peter van Weeterloo ***@***.***>; Mention ***@***.***>
Onderwerp: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] event LEDs mode, pragma once, PID knob_led interaction, preheatdone sound, small fixes and cleanup (#1209)
@digant73<https://github.com/digant73> Could you mabye look at this PR and finish it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI2VWAPDQAJAR7XYQIOONODUDD7KXANCNFSM4S7Z354Q>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@traffic-light Any progress? |
@digant73 Maby you could make the Led Knob Color Change On Progress instead? |
I think @digant73 will get to it eventually. He's made a lot of changes that are amazing. |
Good evening everyone,
I don't know, if you and @digant73 are buddies, 🤷♂️ but unless you are not, than I recommend to not speak up about his schedules. 😊 We all should be grateful to this kind of people, who are enabling us, to have all the nice features, UIs ...
As @traffic-light stated:
He obviously is planning on continuing his work, but this takes time! I think I am able to share your excitement about this getting done, since I a have been there myself, in the not to distant past. 😔 Hopefully no one is offended, since that was not my intent! kind regards |
I'm so sorry that it took soo much time to react to this.. At the moment it's also going better with me as person, for now. I don't know when I have time enough to finish this project/ restart. If someone want to take this project and finish it, feel free |
Thanks for your comment ;-) It's better too see this in my mailbox instead of people crying for digant. Thats why i did a comment right now |
@traffic-light These features have been implemented, and you can cancel the merge request. Thanks for your help! |
I'm having some time due to my almost finisdhed school (no exams. Just 1 excercise) (yes i should be ashamed of myself. Still not done.) and having covid again :-P I installed the newest version of the firmware (my previous one was more then 1 year old) |
Hi Peter. 2x COV. HOW!!?? |
Hi oldman. Omicron is different. But it feels like the common cold for me. |
It is great that you are back! |
Whats inside this PR
Please use the version in the link below. The current version was not intended to push and is not tested and buggy.
https://github.com/traffic-light/BIGTREETECH-TouchScreenFirmware_peter/tree/2551f6447b753540c3e9ca6f9a7df0c3770da1a6
printer event LEDs mode workaround
During printing:
This will also happen to the RGB led of the encoder wheel (when available).
The only difference is that the knob won't turn into white but will be the color that's configured in the feature menu.
For developers
Linked issues that will be implemented / resolved
Why is this a draft?
I'm still working on it. It will cost some time. If you have any ideas or advise, please leave a comment