Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Smart RGB encoder control #1072

Closed
LordBBQ opened this issue Sep 10, 2020 · 36 comments · Fixed by #2286
Closed

[FR] Smart RGB encoder control #1072

LordBBQ opened this issue Sep 10, 2020 · 36 comments · Fixed by #2286
Labels
Abandoned enhancement New feature or request

Comments

@LordBBQ
Copy link

LordBBQ commented Sep 10, 2020

It would be very useful to be able to have the encoder LED change colour based on the current printer state, like in marlin when using the touchscreen.

Example:
Idle: Off
Heater: from blue to red
Print: white
Completion: green
Idle: Off
@LordBBQ LordBBQ added the enhancement New feature or request label Sep 10, 2020
@traffic-light
Copy link
Contributor

traffic-light commented Sep 10, 2020 •
edited
Loading

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).
When heating is done it become the colour you did set in the feature settings
When the print is finished it will be green.

When leaving the print menu it will be, again, the colour you did set in the feature settings

I also implemented it so that the neopixel will do the same as it would when printing form marlin:
Heating: Blue to red
Printing: White
Done: Green

I will also make the colour of the knob red when PID tuning is buzzy and green when ready ;-)

I can't test my code. My screen is broken. So you've got to wait ;-)

What screen type do you use?
I could send you a binary to test my current progress.

(You can find the code here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/compare/master...traffic-light:neopixel_sequential_whileprint?expand=1

It needs some fine tuning. But I hope it works. Can't test it....)

@traffic-light
Copy link
Contributor

A better link:

https://github.com/traffic-light/BIGTREETECH-TouchScreenFirmware_peter/tree/neopixel_sequential_whileprint

(Pasted the wrong one before 😬 )

@LordBBQ
Copy link
Author

LordBBQ commented Sep 12, 2020

Thanks. My TFT35 E3 should come soon and I should be able to test it shortly.

@thisiskeithb
Copy link
Contributor

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).

Please make this configurable/allow it to be disabled.

@traffic-light
Copy link
Contributor

traffic-light commented Sep 13, 2020 •
edited
Loading

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).

Please make this configurable/allow it to be disabled.

That's already implemented ;-)
You can turn it on or off in the feature menu.

I don't see any reason to make it configurable

@thisiskeithb
Copy link
Contributor

That's already implemented ;-)

I’m aware you can change the default knob LED color or on/off state.

I don't see any reason to make it configurable

For users who don’t want the knob color to change while heating/prefer the static (on or off) state instead.

@traffic-light
Copy link
Contributor

traffic-light commented Sep 13, 2020 •
edited
Loading

I don't see any reason to make it configurable

For users who don’t want the knob colour to change while heating/prefer the static (on or off) state instead.

As already mentioned.. I already implemented this in my code. You can turn off the sequential mode.

(maybe i was not clear for you. but it's implemented in my fork...)

@thisiskeithb
Copy link
Contributor

(maybe i was not clear for you. but it's implemented in my fork...)

I didn’t try your fork. I’m just asking that it be configurable/disabled by default when you put in a PR here.

@traffic-light
Copy link
Contributor

traffic-light commented Sep 13, 2020 via email •
edited
Loading

@oldman4U
Copy link
Contributor

Hi. What is the status of the development?

@traffic-light
Copy link
Contributor

The status is: waiting for my package to arrive .. I'm starting to be annoyed by the slooooow delivery......
CGO / Depart from airport
2020-09-12 21:03

深东凤岗仓 / Depart from facility to service provider.
2020-09-04 09:23

深东凤岗仓 / Shipment arrived at facility and measured.
2020-08-25 15:28

深东凤岗仓 / 4px picked up shipment.
2020-08-25 15:28

@oldman4U
Copy link
Contributor

oldman4U commented Sep 28, 2020 via email

@traffic-light
Copy link
Contributor

hahah. that would be nice. The most annoying thing is that they also ship from europe since a short time...

@oldman4U
Copy link
Contributor

oldman4U commented Sep 28, 2020 via email

@traffic-light
Copy link
Contributor

traffic-light commented Sep 28, 2020 via email

@oldman4U
Copy link
Contributor

oldman4U commented Oct 7, 2020

Hi traffic-light. Are you still waiting for the TFT? Or are you working on something w?

@traffic-light
Copy link
Contributor

traffic-light commented Oct 7, 2020 •
edited
Loading

Hi traffic-light. Are you still waiting for the TFT? Or are you working on something w?

Yes... It's still not here.... Still waiting for it to arrive at the airport. And then i've got to wait until the customs think it's okay to send to the Netherlands where i live.

I'll never order again through biqu.equipment. it's horribly slow. And they can't say: Its because of covid19. (Other chinese webshops, like banggood, can deliver 2 times as fast. Im already waiting since 23th of august)

It's a little bit demotivating me to make code and functions for BTT (if you add the bad solution they provide because they screwed something up)

@oldman4U
Copy link
Contributor

oldman4U commented Oct 7, 2020

Maybe we should further improve your readme first in the meantime and maybe also work on the FR list. Do you have an idea how this could work best?

@traffic-light
Copy link
Contributor

traffic-light commented Oct 7, 2020 •
edited
Loading

Maybe we should further improve your readme first in the meantime and maybe also work on the FR list. Do you have an idea how this could work best?

Would love to do that. But the problem is that i'm currently do a graduation internship and I've 4 re-exams.. So.. I don't have a lot of time for myself. So I'll have to finish that first...

It should be finished in march. From then on I'm an Embedded Systems Engineer :-P

The PR part:
Maybe a message in issues where everyone can post where he/ she is working on.

@oldman4U
Copy link
Contributor

oldman4U commented Oct 7, 2020

Hey. Good luck!!

Wrong priorities for me, but if you think this is important for you....🤪

@traffic-light
Copy link
Contributor

Haha yes. I wan't to finish it as soon as possible ;-)

My loan is already too high -_-'

@oldman4U
Copy link
Contributor

oldman4U commented Oct 7, 2020 via email

@traffic-light
Copy link
Contributor

traffic-light commented Oct 7, 2020 via email

@oldman4U
Copy link
Contributor

oldman4U commented Oct 7, 2020 via email

@oldman4U
Copy link
Contributor

OK. I am working on the FR list and it is almost done.

Not sure how far this project has been going so far, but finally this ticket is s duplicate of #634, so could you please be so kind and close this ticket.

The feature itself will be part of this list of course!

Thank you

This was referenced Oct 11, 2020
Closed
Closed
@Mactastic1-5
Copy link

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).
When heating is done it become the colour you did set in the feature settings
When the print is finished it will be green.

When leaving the print menu it will be, again, the colour you did set in the feature settings

I also implemented it so that the neopixel will do the same as it would when printing form marlin:
Heating: Blue to red
Printing: White
Done: Green

I will also make the colour of the knob red when PID tuning is buzzy and green when ready ;-)

I can't test my code. My screen is broken. So you've got to wait ;-)

What screen type do you use?
I could send you a binary to test my current progress.

(You can find the code here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/compare/master...traffic-light:neopixel_sequential_whileprint?expand=1

It needs some fine tuning. But I hope it works. Can't test it....)

What about adding an Auto button to the LED controls on the TFT? There is an OFF button and buttons to change the color, but no AUTO.

@traffic-light
Copy link
Contributor

My screen and mainboard Will be delivered today :-D

@oldman4U
Copy link
Contributor

Holy moly!!!! This is 😊

@oldman4U
Copy link
Contributor

Which mainboard?

@traffic-light
Copy link
Contributor

It's still a dream 😝
But I received it :-)

IMG_20201024_141817

And looks like it's working correctly

@traffic-light
Copy link
Contributor

It's exactly 2 months ago I did place the order ;-)

@oldman4U
Copy link
Contributor

But worth the time 😁 SKR TURBO.

@oldman4U
Copy link
Contributor

It's still a dream 😝

But I received it :-)

IMG_20201024_141817

And looks like it's working correctly

So you don't need any help with connecting and firmware update!!?? A bit disappointing I must say😎

@traffic-light
Copy link
Contributor

traffic-light commented Oct 24, 2020 •
edited
Loading

Hhahahaha

I received some error when stating the UBL probe. Probing failed... Can't figure out the problem. Can you huys help me? What did i do wrong

See my setup in the image before...

@traffic-light traffic-light mentioned this issue Oct 26, 2020
Closed
@oldman4U oldman4U mentioned this issue Nov 11, 2020
Closed
@stale
Copy link

stale bot commented Dec 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Abandoned label Dec 23, 2020
@stale stale bot closed this as completed Dec 30, 2020
@digant73 digant73 mentioned this issue Dec 16, 2021
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Abandoned enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@thisiskeithb @Mactastic1-5 @traffic-light @LordBBQ @oldman4U