Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TFT display does not support the progress LED. #634

Closed
AntoszHUN opened this issue Apr 28, 2020 · 8 comments · Fixed by #2286
Closed

The TFT display does not support the progress LED. #634

AntoszHUN opened this issue Apr 28, 2020 · 8 comments · Fixed by #2286
Labels
Abandoned enhancement New feature or request

Comments

@AntoszHUN
Copy link
Contributor

Is it possible that the Printer Event LEDs feature will be included in the TFT display firmware at some point? Marlin knows. It also works nicely in Marlin Mode. But not in touch screen mode anymore. Do you know anything about this?

Hello! AntoszHUN

@AntoszHUN AntoszHUN added the enhancement New feature or request label Apr 28, 2020
@GregSKR
Copy link
Contributor

GregSKR commented May 4, 2020

That would be great!

@oldman4U
Copy link
Contributor

Jonapot.

Does this cover your feature request?

@traffic-light
Copy link
Contributor

traffic-light commented Oct 11, 2020

Copy from #1072 :

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).
When heating is done it become the colour you did set in the feature settings
When the print is finished it will be green.

When leaving the print menu it will be, again, the colour you did set in the feature settings

I also implemented it so that the neopixel will do the same as it would when printing form marlin:
Heating: Blue to red
Printing: White
Done: Green

I will also make the colour of the knob red when PID tuning is buzzy and green when ready ;-)

I can't test my code. My screen is broken. So you've got to wait ;-)

What screen type do you use?
I could send you a binary to test my current progress.

https://github.com/traffic-light/BIGTREETECH-TouchScreenFirmware_peter/tree/neopixel_sequential_whileprint

It needs some fine tuning. But I hope it works. Can't test it....)

@GregSKR
Copy link
Contributor

GregSKR commented Oct 15, 2020

@traffic-light Nice work, but I cant test it, my screen is a TFT35 v2.0 without encoder knob, so I have no calls to loopDimTimer()
My NeoPixel LEDs are pluged on my SKR v1.3, I do not have encoder LEDs...

BTW, I see in your code that you're using M150 commands with "G" letter for green:

      //Set neopixel and ledknob to green
      storeCmd("M150 R0 G255 B0");

But the letter for green is "U", if I'm not wrong: https://marlinfw.org/docs/gcode/M150.html
Like there:

storeCmd("M150 R0 U255 B0 P255\n");

@traffic-light
Copy link
Contributor

It's also for neopixels ;-)

Thanks for the feedback on the green neopixel command. Did not look good enough in the gcode I think

I will fix things that are not right at this moment when I've got some time and when bigtreetech decides what to do with the memory problem

@oldman4U
Copy link
Contributor

Hi AntoszHUN.

Could you please close this ticket. Your requested feature is under development and you could help us to keep this ticket system usable by closing this ticket.

Thank you

@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Apr 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.