Release - August 2018 - Target RC date: 2018-08-01 - name: 0.17.0

[dslomov]

No description provided.

[dslomov]

@jin lmk if you are not available on these dates

[dkelmer]

Can we delay cutting the release until #3115 is fixed? I'm aiming to mail a fix today

[buchgr]

@dkelmer if it's a regression we can also cherry pick it

[dkelmer]

That works too. rules_go is definitely broken and I imagine other projects are too

[jin]

Using Aug 3 nightly: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/368

Status

On hold, blocked on:

• Embedded JVM fix
• Resolution for .bazelrc read order changes

Release blockers

• rules_apple: @sergiocampama's fix is in rules_apple failing with downstream projects #5683.
• bazel_toolchains: Maintainer is unable to reproduce, pulling in engprod. Many tests failing on Buildkite nightly bazel-toolchains#143
• rules_go. Pending rollback by @dkelmer @ and @workspacename considered different repositories #3115
• All issues related to the bazelrc change at Change where bazelrcs are read from, and make it easier to control which ones are read. #4502 (@cvcal). See Nightly: breakages from bazelrc read order changes #5756 for the list
• Remote execution. Nightly, Remote Execution: All tests failing #5761
• Tensorflow: ERROR: Unrecognized option: --experimental_shortened_obj_file_path=true
  Tensorflow downstream failing on windows  #5677

Also: all Windows pipelines are failing due to #5749

Ignore

• rules_python: //examples/boto:boto_test still failing. There have been 3 releases with this failure. boto_test broken on mac rules_python#98

Baseline

afebc60

To cherrypick

For tensorflow:
510aca0

For rules_apple:
f330439

For mainrepo changes affecting rules_go

ed598bc

[jin]

Pushing 0.17.0rc1

scripts/release/release.sh create 0.17.0 afebc60a337e98aa7b5b4f45cc809dae5cd0c765 510aca0c993d89cccdf2da1b8bcafff35a0d030f

[petemounce]

Pushed to chocolatey.

[jin]

RC1 pushed https://releases.bazel.build/0.17.0/rc1/index.html

[drigz]

Can I suggest adding a blocker for some simple migration instructions for #4502? As you can see it breaks lots of projects, and there are questions on #4502 and one on bazel-discuss about how to migrate - in particular for teams that use both %workspace%/.bazelrc and tools/bazel.rc but only have one of them in the repo.

[cvcal]

Yes, we'll make sure there are migration instructions in the release notes. Is there somewhere else you think we should add instructions?

…

On Tue, Aug 7, 2018 at 9:25 AM Rodrigo Queiro ***@***.***> wrote: Can I suggest adding a blocker for some simple migration instructions for #4502 <#4502>? As you can see it breaks lots of projects, and there are questions on #4502 <#4502> and one on bazel-discuss <https://groups.google.com/forum/?pli=1#!topic/bazel-discuss/IWEA7npKNYg> about how to migrate. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5059 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGPQ46s-l0U6dQFdmn9nfrDLS9XHpRKsks5uOZVGgaJpZM4TbvBB> .

[buchgr]

@jin I think due to the regressions in the 0.16.0 release regarding the embedded JDK and Java rules we'll need to put the 0.17.0 release on hold for now.

[jin]

@buchgr will do - thanks for the update.

[drigz]

@cvcal I guess there's a chicken/egg problem, but it would be ideal to link them from the warning. Otherwise a noticeable mention in the release notes seems sufficient.

PS. The warning is not colored for me, so it doesn't stand out so much from the stdout-spam[1], is that expected?

[1]: I have, to my great shame, failed to stop this building up in our project.

[cvcal]

Unfortunately, yes - the warning is printed from the C++ client, not the server, which is where the colored lines come from. I know this makes it less noticeable, and that's sad...
I could get around this by sending the server --unconditional_warning=blah but adding command arguments from the client is something we really try not to do

[drigz]

No problem, thanks for the clarification. Maybe other people have cleaner builds :) Thanks for being so responsive the whole way through on this change by the way!

[jin]

As of @dslomov's email in https://groups.google.com/forum/#!topic/bazel-discuss/1116GHzkNm0, we'll put 0.17.0 on hold until we cut a new 0.16.1 release with the fixes to the embedded JDK 9.

[buchgr]

We are expecting to release 0.16.1 on Monday, 13th August based on this release candidate https://releases.bazel.build/0.16.1/rc2/index.html

[davido]

we'll put 0.17.0 on hold until we cut a new 0.16.1 release with the fixes to the embedded JDK 9.

It seems that Gerrit cannot be built any more on JDK9 on 0.17.0rc1 and master, see #5896.

[jin]

Reassigning to the new release team @aehlig @philwo @katre @laurentlb

[laurentlb]

What is the current state of 0.17? I see that 0.16.1 has been released (https://github.com/bazelbuild/bazel/releases).

I can cut a new 0.17, with the same baseline and cherrypick as https://releases.bazel.build/0.17.0/rc1/index.html. On top of that, I can also cherrypick everything that went into 0.16.1. Is that correct?

[cvcal]

Issues #5765 and #5906 have a pending fix which should get included in 0.17

[gertvdijk]

Was it intended to create a 0.17.1 RC release? I expected a 0.17.0 RC3. 😄

[laurentlb]

Yes. 0.17.0 was abandoned, 0.17.1 was created using a different baseline.

[laszlocsomor]

Please cherrypick 9323c57 to fix #6099.

[laurentlb]

Done, 9323c57 added.
New candidate is here: https://releases.bazel.build/0.17.1/rc4/index.html

I think all known issues have been fixed. If nothing new is reported, we should release this week.

[iirina]

Please also cherry pick 1aba9ac. Envoy build breaks without it.

[laurentlb]

Done. This is 0.17.1rc5: https://releases.bazel.build/0.17.1/rc5/index.html

Created using:
scripts/release/release.sh create --force_rc=5 0.17.1 aa118ca 0e04625 3987300 438b277 5044017 9ed9d8a 22d761a 27303d7 ddc97ed ead1002 12dcd35 7eb9ea1 4566a42 1e9f0aa a572c1c 29f1de0 b495eaf 9323c57 1aba9ac

[ittaiz]

FYI- I think #6121 will be a release blocker but I just filed it so obviously no one triaged it yet.

[petemounce]

RCs 2, 3, 4, 5 all published to chocolatey.

[davido]

@laurentlb There is another release blocker: Gerrit cannot be built on Java 9 any more: #6127. There is no fix available yet.

[cushon]

@laurentlb @lberki the fix for #6127 was submitted as 2579b79

[laurentlb]

Should I delay the release again, or can we use this commit in a patch release?

[laurentlb]

Cherrypicked both 2579b79 and 2834613.

https://releases.bazel.build/0.17.1/rc7/index.html
 
Created with:
scripts/release/release.sh create --force_rc=7 0.17.1 aa118ca 0e04625 3987300 438b277 5044017 9ed9d8a 22d761a 27303d7 ddc97ed ead1002 12dcd35 7eb9ea1 4566a42 1e9f0aa a572c1c 29f1de0 b495eaf 9323c57 1aba9ac 2579b79 2834613

[petemounce]

In the release notes, are the second and third accurate?

If the same artifact is generated by two distinct but identical actions, and a downstream action has both those actions' outputs in its inputs, the artifact will now appear twice in the downstream action's inputs. If this causes problems in Skylark actions, you can use the uniquify=True argument in Args.add_args.
If the same artifact is generated by two distinct but identical actions, and a downstream action has both those actions' outputs in its inputs, the artifact will now appear twice in the downstream action's inputs. If this causes problems in Skylark actions, you can use the uniquify=True argument in Args.add_args.

[laurentlb]

I think so. The draft release announcement is here: https://docs.google.com/document/d/1wDvulLlj4NAlPZamdlEVFORks3YXJonCjyuQMUQEmB0/edit#heading=h.fdnt5bpp42hj

(we don't update the generated release notes, so they sometimes have issues)

[ittaiz]

@laurentlb any idea if we'll have a release today/tomorrow or not?

[laurentlb]

I plan to release it tomorrow morning.

Sorry for the delays

[laurentlb]

Released: https://github.com/bazelbuild/bazel/releases/tag/0.17.1
(cc @petemounce @ilovezfs)

The announcement will be published on the website later today.

[buchgr]

@laurentlb ilovezfs is no longer doing homebrew. as mentioned in the release guide you need to update our own homebrew tap: https://github.com/bazelbuild/homebrew-tap

[petemounce]

Pushed to chocolatey.

[jin]

@laurentlb It looks like we need to make a 0.17.2 point release containing 2e677fb

Brief summary: 0.17 introduces a regression where Android apps can't be built at the desugaring step when used in conjunction with a manual --host_javabase flag pointing to a JDK 8 installation. The above commit fixes this regression.

Please see #6159 (comment) for more details.

cc @cushon

[steeve]

@jin it would be nice if it could include the fix for #6151 as well

[jin]

@steeve unfortunately the cherrypick policy doesn't cover that.

[steeve]

@jin that's too bad, since this one generates lots and lots of warnings during Android builds and thus creates a lot of noise and I think will make people think this are not working as they should.

Although 2e677fb fixes it by forcing a build with JDK8 (with the workaround found in #5978)

[laurentlb]

Please use the new bug for discussing cherrypick requests (#6164).