Bazel release 0.17.2 #6164

laurentlb · 2018-09-17T10:49:36Z

This issue is for tracking a patch release on top of 0.17.1 (#5059).

Release policy: https://bazel.build/support.html#policy

we do not cherry-pick new features into it. Moreover, if we discover that a new feature is buggy, we might decide to roll it back from a release candidate. Only critical, high-impact bugs will be fixed in a release candidate.

laurentlb · 2018-09-17T10:53:03Z

Request 1 by @jin is 2e677fb
Is there a tracking bug about it? How is it critical?

Request 2 by @steeve is #6151
This seems to be a regression, but it is not breaking users. @cushon, can you comment on the impact on user-experience?

jin · 2018-09-17T15:23:23Z

Request 1 by @jin is 2e677fb
Is there a tracking bug about it? How is it critical?

Brief summary: 0.17 introduces a regression where Android apps can't be built at the desugaring step when used in conjunction with a manual --host_javabase flag pointing to a JDK 8 installation.

If an Android target can't be built using a user-accessible manner that was previously possible, I consider this a critical regression.

2e677fb fixes this regression.

Tracking bug: #6159

cushon · 2018-09-17T16:31:11Z

Request 2 by @steeve is #6151
This seems to be a regression, but it is not breaking users. @cushon, can you comment on the impact on user-experience?

I don't think #6151 is a regression since 0.16x, since that release also used an embedded JDK 9 which would have generated the same warnings. The issue results in some warning spam in the build log, which is annoying but ultimately harmless.

jin · 2018-09-17T23:07:24Z

@laurentlb FYI, looks like the fix for this issue with 0.17.0rc1 didn't make it into 0.17.1: #5974

aehlig · 2018-09-18T11:52:12Z

@laurentlb FYI, looks like the fix for this issue with 0.17.0rc1 didn't make it into 0.17.1: #5974

...which is technically correct according to our policy. .bazelignore is a new feature, strictly opt-in, as so far no one had a reason to have a file called .bazelignore in their work space. And that new feature happened to be broken and will be useful only in 0.18; but it is not technically a regression, as it didn't work in any earlier release either. Unfortunate, but following our policies.

laurentlb · 2018-09-18T11:59:18Z

Correct. The goal of patch releases is to make sure that users can upgrade from 0.16 to 0.17. So if a change in 0.17 blocks you from upgrading, we can cherrypick the fix. In other cases, you'll have to wait for the next release (but it's not too bad, I think: we release once a month on average).

I'm going to create a candidate with one cherrypick: 2e677fb

cushon · 2018-09-19T04:56:25Z

@laurentlb consider including 1d956c7 for #6180, which is a regression in 0.17.1. (cc @mhlopko @iirina)

laurentlb · 2018-09-19T15:13:31Z

0.17.2 rc1 is available here: https://releases.bazel.build/0.17.2/rc1/index.html

scripts/release/release.sh create 0.17.2 7bb9e0f 1d956c7 2e677fb

steeve · 2018-09-19T22:25:05Z

This version outputs these warnings when installing, FYI:

Uncompressing......Extracting Bazel installation...
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/private/var/tmp/_bazel_steeve/install/2269f5a83016b62a56b593c692184ca4/_embedded_binaries/A-server.jar) to field java.lang.String.value
WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".

steeve · 2018-09-19T22:30:37Z

This version fails with:

ERROR: /Users/steeve/go/src/github.com/steeve/project/BUILD.bazel:79:1: Sharding classes for dexing for //:myandroidapp failed (Exit 1): mapper failed: error executing command
  (cd /private/var/tmp/_bazel_steeve/309ac22c92b055a3e3f78825fe63406b/execroot/__main__ && \
  exec env - \
    PATH=/bin:/usr/bin \
  bazel-out/host/bin/external/bazel_tools/src/tools/android/java/com/google/devtools/build/android/ziputils/mapper --output_jar bazel-out/x86-fastbuild/bin/android/_dx/zenlycore_split/classes.jar --output_resources bazel-out/x86-fastbuild/bin/myandroidapp_files/java_resources.jar --split_dexed_classes --input_jar bazel-out/x86-fastbuild/bin/myandroidapp_resources.jar.dex.zip)
Exception in thread "main" java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
	at com.google.devtools.build.android.ziputils.ZipIn.loadEndOfCentralDirectory(ZipIn.java:491)
	at com.google.devtools.build.android.ziputils.ZipIn.endOfCentralDirectory(ZipIn.java:96)
	at com.google.devtools.build.android.ziputils.SplitZip.run(SplitZip.java:294)
	at com.google.devtools.build.android.ziputils.DexMapper.main(DexMapper.java:70)

in .bazel.rc:

build                   --javabase=@local_jdk//:jdk
build                   --host_javabase=@local_jdk//:jdk
build                   --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8
build                   --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8

0.16.1 works

cushon · 2018-09-19T23:07:44Z

@steeve I tried building //examples/android/... with 0.17.2 rc1 and JDK 8 and wasn't able to observe that problem, can you share the repro?

steeve · 2018-09-20T00:18:13Z

I won't have my computer until the morning but until I do you can try https://github.com/steeve/bazel_issue_5978

steeve · 2018-09-20T00:18:44Z

With --config jdk8

jin · 2018-09-20T06:12:03Z

I'm getting a different error with 0.17.2rc1 with https://github.com/steeve/bazel_issue_5978 now:

$ bazel build //:sample --config=jdk8 --strategy=Javac=sandboxed
INFO: Analysed target //:sample (0 packages loaded).
INFO: Found 1 target...
ERROR: /private/var/tmp/_bazel_jingwen/8b561bac257f9f14a669861c2ced5081/external/androidsdk/BUILD.bazel:8:1: Building external/androidsdk/apksigner.jar () failed (Exit 1)
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
-Xbootclasspath/p is no longer a supported option.
Target //:sample failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.470s, Critical Path: 0.23s
INFO: 1 process: 1 darwin-sandbox.
FAILED: Build did NOT complete successfully

cushon · 2018-09-20T06:19:56Z

@jin what's your local JDK version / JAVA_HOME? The -Xbootclasspath/p error looks like you have a local JDK 9, which isn't going to work with --config=jdk8.

I can build https://github.com/steeve/bazel_issue_5978 with all of the following configurations:

JAVA_HOME=$JAVA8_HOME bazel-0.17.2rc1-linux-x86_64 build --config=jdk8 //:sample
JAVA_HOME=$JAVA8_HOME bazel-0.17.2rc1-linux-x86_64 build //:sample
JAVA_HOME=$JAVA9_HOME bazel-0.17.2rc1-linux-x86_64 build //:sample

jin · 2018-09-20T06:27:59Z

That explains it. Sorry for the noise!

…

On Thu, Sep 20, 2018 at 2:20 PM Liam Miller-Cushon ***@***.***> wrote: @jin <https://github.com/jin> what's your local JDK version / JAVA_HOME? The -Xbootclasspath/p error looks like you have a local JDK 9, which isn't going to work with --config=jdk8. I can build https://github.com/steeve/bazel_issue_5978 with all of the following configurations: JAVA_HOME=$JAVA8_HOME bazel-0.17.2rc1-linux-x86_64 build --config=jdk8 //:sample JAVA_HOME=$JAVA8_HOME bazel-0.17.2rc1-linux-x86_64 build //:sample JAVA_HOME=$JAVA9_HOME bazel-0.17.2rc1-linux-x86_64 build //:sample — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6164 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVPDkPv_x7dmKWC3OkSen2gjr_RbJV_ks5uczOQgaJpZM4WrqxA> .

cushon · 2018-09-20T06:43:07Z

I think I have an explanation for the NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; error reported in #6164 (comment).

I was trying to reproduce on linux, and the version of com.google.devtools.build.android.ziputils.ZipIn in bazel-0.17.1-darwin-x86_64 doesn't match the linux binary:

wget https://releases.bazel.build/0.17.2/rc1/bazel-0.17.2rc1-{linux,darwin}-x86_64
JAR=embedded_tools/src/tools/android/java/com/google/devtools/build/android/all_android_tools_deploy.jar
CLASS=com.google.devtools.build.android.ziputils.ZipIn
unzip -o bazel-0.17.2rc1-darwin-x86_64 $JAR && javap -v -p -cp $JAR $CLASS | grep ByteBuffer.position
unzip -o bazel-0.17.2rc1-linux-x86_64 $JAR && javap -v -p -cp $JAR $CLASS | grep ByteBuffer.position

Archive:  bazel-0.17.2rc1-darwin-x86_64
  inflating: embedded_tools/src/tools/android/java/com/google/devtools/build/android/all_android_tools_deploy.jar  
  #124 = Methodref          #208.#382     // java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer;
       230: invokevirtual #124                // Method java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer;
Archive:  bazel-0.17.2rc1-linux-x86_64
  inflating: embedded_tools/src/tools/android/java/com/google/devtools/build/android/all_android_tools_deploy.jar  
  #124 = Methodref          #208.#382     // java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;
       230: invokevirtual #124                // Method java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;

The issue affecting the darwin binary looks identical to #5978 (comment), which we fixed by adding a step to the release pipeline to build the release with itself: #5978 (comment).

@philwo any chance that change was only made for the linux release pipeline and not for darwin?

cushon · 2018-09-20T06:49:51Z

any chance that change was only made for the linux release pipeline and not for darwin?

I think that's what happened. Diffing the linux [1] and darwin [2] release configs, I see:

--- darwin   2018-09-19 23:45:10.380907192 -0700
+++ linux   2018-09-19 23:45:15.880890494 -0700
@@ -3,5 +3,5 @@
 mkdir output
 cp bazel-bin/src/bazel output/bazel
 
-bazel build --define IPHONE_SDK=1 -c opt --stamp --embed_label \"${release_name}\" --workspace_status_command=scripts/ci/build_status_command.sh src/bazel scripts/packages/with-jdk/install.sh
+output/bazel build -c opt --stamp --embed_label \"${release_name}\" --workspace_status_command=scripts/ci/build_status_command.sh src/bazel scripts/packages/with-jdk/install.sh scripts/packages/debian/bazel-debian.deb scripts/packages/debian/bazel.dsc scripts/packages/debian/bazel.tar.gz bazel-distfile.zip

We should be using output/bazel on both for that step, not just for linux.

[1] https://buildkite.com/bazel/release/builds/105#6874f846-9cff-469b-9095-a692db9f3006
[2] https://buildkite.com/bazel/release/builds/105#dcf156e2-41d0-4538-922f-a898c68ab849

philwo · 2018-09-20T11:04:38Z

Arghh, sorry :( Indeed, I must have missed that when updating the pipeline. I'll make the fix right now.

philwo · 2018-09-20T12:53:06Z

Fixed. All builds in the "release pipeline" from now on will use the fixed configuration.

laurentlb · 2018-09-20T13:49:11Z

I'm a bit confused with the messages.
Is there anything to cherrypick on top of 0.17.2 rc1? Is there still a blocking issue?

philwo · 2018-09-20T13:52:58Z

AFAIU, we don't have to cherrypick anything in order to fix the error that @cushon mentioned above, as the problem was only in our CI pipeline configuration (which I fixed now).

The next time you or anyone else builds a release candidate or a final release, the release binary on macOS will be built in the correct way (the same as on Linux and Windows) and that should fix the error.

cushon · 2018-09-20T14:20:49Z

Thanks @philwo!

@laurentlb can you build another release candidate (with no additional cherry-picks) so the fix to the release pipeline can be verified before the final release?

steeve · 2018-09-20T15:58:26Z

Is it possible to make an 0.17.2rc2 then? Or overwrite the 0.17.2rc1 with the new release pipeline.

laurentlb · 2018-09-20T17:02:25Z

Done.
https://releases.bazel.build/0.17.2/rc2/index.html

cushon · 2018-09-20T17:32:07Z

Thanks, looks good to me:

Archive:  bazel-0.17.2rc2-darwin-x86_64
  inflating: embedded_tools/src/tools/android/java/com/google/devtools/build/android/all_android_tools_deploy.jar  
  #124 = Methodref          #208.#382     // java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;
       230: invokevirtual #124                // Method java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;
Archive:  bazel-0.17.2rc2-linux-x86_64
  inflating: embedded_tools/src/tools/android/java/com/google/devtools/build/android/all_android_tools_deploy.jar  
  #124 = Methodref          #208.#382     // java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;
       230: invokevirtual #124                // Method java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;

@steeve can you verify that fixes the problem you were seeing?

steeve · 2018-09-20T18:24:24Z

I can confirm that rc2 fixes the jdk8 issue!

laurentlb · 2018-09-21T13:06:40Z

Bazel 17.2 released: https://github.com/bazelbuild/bazel/releases/tag/0.17.2

(cc @vbatts @petemounce)

vbatts · 2018-09-21T14:58:14Z

https://copr.fedorainfracloud.org/coprs/vbatts/bazel/build/801272/ I tried it locally, and it compiled fine for centos. Hopefully #6150 is not an issue any longer.

petemounce · 2018-09-24T22:15:04Z

Pushed to chocolatey

dimsuz · 2018-12-13T16:40:33Z

Hmm, I still see this with bazel-0.20.0 on Arch Linux. I'm trying to follow an official Android Tutorial.

The command bazel build //src/main:app gives me a 'Can't start JVM' error, so I figured that's because I use java 8 (because Android):

$ javac -version
javac 1.8.0_192

So I try to tell bazel about this:

bazel build --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 //src/main:app

And get an error in response:

INFO: Invocation ID: 6850ce2f-2b64-4627-8377-966538caba8d
INFO: Build options have changed, discarding analysis cache.
INFO: Analysed target //src/main:app (0 packages loaded, 957 targets configured).
INFO: Found 1 target...
ERROR: /home/dima/tmp/bazel-examples/android/tutorial/src/main/BUILD:1:1: Sharding classes for dexing for //src/main:app failed (Exit 1) mapper failed: error executing command bazel-out/host/bin/external/bazel_tools/src/tools/android/java/com/google/devtools/build/android/ziputils/mapper --output_jar bazel-out/k8-fastbuild/bin/src/main/_dx/app/classes.jar --output_resources ... (remaining 6 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
Exception in thread "main" java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
	at com.google.devtools.build.android.ziputils.ZipIn.loadEndOfCentralDirectory(ZipIn.java:491)
	at com.google.devtools.build.android.ziputils.ZipIn.endOfCentralDirectory(ZipIn.java:96)
	at com.google.devtools.build.android.ziputils.SplitZip.run(SplitZip.java:294)
	at com.google.devtools.build.android.ziputils.DexMapper.main(DexMapper.java:70)
Target //src/main:app failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 4.184s, Critical Path: 4.01s
INFO: 23 processes: 13 processwrapper-sandbox, 10 worker.
FAILED: Build did NOT complete successfully

Any hints on how to fix this? (Seeing how all relevant issues are closed I suspect I might be doing something wrong)

jin · 2018-12-13T17:15:06Z

@dimsuz could you please file a new issue and tag me in it? This issue is for the 0.17.2 release.

laurentlb mentioned this issue Sep 17, 2018

Release - August 2018 - Target RC date: 2018-08-01 - name: 0.17.0 #5059

Closed

laurentlb added the release label Sep 17, 2018

cushon mentioned this issue Sep 19, 2018

Cannot find gcov or GCOV with Bazel 0.17.1 #6180

Closed

cushon mentioned this issue Sep 20, 2018

Add //examples/... to RBE CI pipeline #6007

Closed

steeve mentioned this issue Sep 20, 2018

desugar doesn't work with Bazel 0.17.1 and --host_javabase=<jdk8> #6159

Closed

yongtang mentioned this issue Sep 21, 2018

[bazel] Update bazel to 0.17.1 tensorflow/tensorflow#22449

Closed

This was referenced Sep 21, 2018

add a --host_javabase=<jdk8> configuration to buildkite #6205

Closed

Windows 7 Install: WARNING: An illegal reflective access operation has occurred #6197

Closed

iirina mentioned this issue Sep 26, 2018

Bazel 0.17.1 regression: Unrecoverable error while evaluating node #6149

Closed

laurentlb closed this as completed Sep 26, 2018

dimsuz mentioned this issue Dec 13, 2018

Building Android app (official tutorial) fails on Linux with JDK8 #6920

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bazel release 0.17.2 #6164

Bazel release 0.17.2 #6164

laurentlb commented Sep 17, 2018

laurentlb commented Sep 17, 2018

jin commented Sep 17, 2018 •

edited

Loading

cushon commented Sep 17, 2018

jin commented Sep 17, 2018 •

edited

Loading

aehlig commented Sep 18, 2018

laurentlb commented Sep 18, 2018

cushon commented Sep 19, 2018

laurentlb commented Sep 19, 2018

steeve commented Sep 19, 2018

steeve commented Sep 19, 2018 •

edited

Loading

cushon commented Sep 19, 2018

steeve commented Sep 20, 2018

steeve commented Sep 20, 2018

jin commented Sep 20, 2018

cushon commented Sep 20, 2018

jin commented Sep 20, 2018 via email

cushon commented Sep 20, 2018

cushon commented Sep 20, 2018

philwo commented Sep 20, 2018

philwo commented Sep 20, 2018

laurentlb commented Sep 20, 2018

philwo commented Sep 20, 2018

cushon commented Sep 20, 2018

steeve commented Sep 20, 2018 •

edited

Loading

laurentlb commented Sep 20, 2018

cushon commented Sep 20, 2018

steeve commented Sep 20, 2018

laurentlb commented Sep 21, 2018

vbatts commented Sep 21, 2018 via email

petemounce commented Sep 24, 2018

dimsuz commented Dec 13, 2018

jin commented Dec 13, 2018

Bazel release 0.17.2 #6164

Bazel release 0.17.2 #6164

Comments

laurentlb commented Sep 17, 2018

laurentlb commented Sep 17, 2018

jin commented Sep 17, 2018 • edited Loading

cushon commented Sep 17, 2018

jin commented Sep 17, 2018 • edited Loading

aehlig commented Sep 18, 2018

laurentlb commented Sep 18, 2018

cushon commented Sep 19, 2018

laurentlb commented Sep 19, 2018

steeve commented Sep 19, 2018

steeve commented Sep 19, 2018 • edited Loading

cushon commented Sep 19, 2018

steeve commented Sep 20, 2018

steeve commented Sep 20, 2018

jin commented Sep 20, 2018

cushon commented Sep 20, 2018

jin commented Sep 20, 2018 via email

cushon commented Sep 20, 2018

cushon commented Sep 20, 2018

philwo commented Sep 20, 2018

philwo commented Sep 20, 2018

laurentlb commented Sep 20, 2018

philwo commented Sep 20, 2018

cushon commented Sep 20, 2018

steeve commented Sep 20, 2018 • edited Loading

laurentlb commented Sep 20, 2018

cushon commented Sep 20, 2018

steeve commented Sep 20, 2018

laurentlb commented Sep 21, 2018

vbatts commented Sep 21, 2018 via email

petemounce commented Sep 24, 2018

dimsuz commented Dec 13, 2018

jin commented Dec 13, 2018

jin commented Sep 17, 2018 •

edited

Loading

jin commented Sep 17, 2018 •

edited

Loading

steeve commented Sep 19, 2018 •

edited

Loading

steeve commented Sep 20, 2018 •

edited

Loading