rules_apple failing with downstream projects #5683
Comments
|
/sub |
|
@sergiocampama ping, PTAL and rollback if needed. |
|
This breakage was not caused by rules_apple, but by the bazel team making incompatible changes in bazel and then pushing them into rules_apple before they are released and tested. We've updated the code in rules_apple, but integration tests are still broken as there's a missing piece in bazel, which I'm trying to submit right now. Once that happens, would it be possible to cherry pick it into a 0.16.X release? |
|
cc @c-parsons for 0.16.x cherrypicks |
|
@c-parsons Would it be possible to cherrypick f330439? This fixes a discrepancy in how the rules access action_names.bzl internally vs externally. |
|
Could you elaborate on the exact nature of this breakage? I'm at a bit of a loss in understanding why this is needed, as I'd like to entertain the possibility of a workaround before committing to a cherry-pick :) |
|
@sergiocampama previously nightly still has the same error: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/368#efbb1149-2436-4a22-9581-971fa77bb1fe Is f330439 expected to fix that? |
|
Ah, I confused the error, f330439 solves a different breakage. The fix for
this breakage is already out for review internally.
…On Fri, Aug 3, 2018 at 4:41 PM Jingwen ***@***.***> wrote:
@sergiocampama <https://github.com/sergiocampama> today's nightly still
has the same error:
https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/368#efbb1149-2436-4a22-9581-971fa77bb1fe
Is f330439
<f330439>
expected to fix that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqELqc6eFRQJlEmUInPBPtaeiRR6RW8ks5uNLVdgaJpZM4Vio6_>
.
|
|
Thanks - I'll cherrypick that into 0.17.0 rc2. We should also cherrypick that into 0.16.1. |
|
The fix has been submitted: 6bd0bdf |
|
Could f330439 also be cherrypicked? Hopefully into the 0.17 RC, but if it could be added to 0.16.1 that would be awesome :) |
|
We have travis (HEAD) tests working now, we just need 0.16.1 to be released in buildkite to be back into the green again |
Baseline: 4f64b77 Cherry picks: + 4c9a0c8: reduce the size of bazel's embedded jdk + d3228b6: remote: limit number of open tcp connections by default. Fixes #5491 + 8ff87c1: Fix autodetection of linker flags + c4622ac: Fix autodetection of -z linker flags + 1021965: blaze_util_posix.cc: fix order of #define + ab1f269: blaze_util_freebsd.cc: include path.h explicitly + 68e92b4: openjdk: update macOS openjdk image. Fixes #5532 + f45c224: Set the start time of binary and JSON profiles to zero correctly. + bca1912: remote: fix race on download error. Fixes #5047 + 3842bd3: jdk: use parallel old gc and disable compact strings + 6bd0bdf: Add objc-fully-link to the list of actions that require the apple_env feature. This fixes apple_static_library functionality. + f330439: Add the action_names_test_files target to the OSS version of tools/buils_defs/cc/BUILD. + d215b64: Fix StackOverflowError on Windows. Fixes #5730 + 366da4c: In java_rules_skylark depend on the javabase through //tools/jdk:current_java_runtime + 30c601d: Don't use @local_jdk for jni headers + c56699d: 'DumpPlatformClasspath' now dumps the current JDK's default platform classpath This release is a patch release that contains fixes for several serious regressions that were found after the release of Bazel 0.16.0. In particular this release resolves the following issues: - Bazel crashes with a StackOverflowError on Windows (See #5730) - Bazel requires a locally installed JDK and does not fall back to the embedded JDK (See #5744) - Bazel fails to build for Homebrew on macOS El Capitan (See #5777) - A regression in apple_static_library (See #5683) Please watch our blog for a more detailed release announcement.
|
rules_apple is green again |
rules_apple are failing with bazel at head: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/360#c1ba3035-bbe4-4335-a513-36ac4d25ab86
ERROR: /Users/buildkite/builds/buildkite-imacpro-3-1/bazel-downstream-projects/rules_apple/test/testdata/binaries/BUILD:12:1: Couldn't build file test/testdata/binaries/empty_staticlib-fl.a: Linking of rule '//test/testdata/binaries:empty_staticlib' failed (Exit 1)
| /private/var/tmp/_bazel_buildkite/fe5a0746c5b6405e9a95248b5562d68d/sandbox/darwin-sandbox/8/execroot/build_bazel_rules_apple/external/local_config_cc/xcrunwrapper.sh: line 40: SDKROOT: unbound variable
I believe this d69b1c7 is the culprit
The text was updated successfully, but these errors were encountered: