Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, Bazel 0.17.0rc2, regression: bazel no longer writes java.log #6099

Closed
laszlocsomor opened this issue Sep 7, 2018 · 3 comments
Closed

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

0.17.0 rc2 regression over rc1: Bazel on Windows no longer writes <output_base>/java.log.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Build anything with 0.17.0 rc1, then run bazel info output_base, list the reported directory, see java.log is there.
Do the same with rc2, see that java.log is not there.

What operating system are you running Bazel on?

Windows 10 v1709

@laszlocsomor
Copy link
Contributor Author

I found the root cause: similarly to #2576, it's the java log path. Turns out we must pass the path with escaped backslashes instead of forward slashes. Working on a fix.

@lberki
Copy link
Contributor

lberki commented Sep 7, 2018

How come it worked in 0.17rc1 then?

@laszlocsomor
Copy link
Contributor Author

I don't know yet. What I do know is that (a) the fix solves this issue, and (b) the fix removes an exception from the <output_base>/server/jvm.out that I've been aware of for a long time, but which never seemed to result in any problems (until now?).

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Sep 7, 2018
Fixes bazelbuild#6099
Fixes bazelbuild#6098
Related to bazelbuild#2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc
laurentlb pushed a commit that referenced this issue Sep 10, 2018
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 10, 2018
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 12, 2018
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 12, 2018
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants