Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use convert runtime API and enable disabled tests in http #3933

Closed
Nadeeshan96 opened this issue Jan 13, 2023 · 1 comment
Closed

Use convert runtime API and enable disabled tests in http #3933

Nadeeshan96 opened this issue Jan 13, 2023 · 1 comment

Comments

@Nadeeshan96
Copy link

Nadeeshan96 commented Jan 13, 2023

Description:

$title

Describe your task(s)

  1. In some standard libraries cloneWithType.convert(), fromJsonWithType.convert(), cloneWithType, and fromJsonWithType java methods are used in the native code. After fixing Provide a runtime API to clone a value to a type ballerina-lang#35141, we can use this instead of them. We need to replace the usages to use the runtime API.
    https://github.com/search?l=Java&q=org%3Aballerina-platform+CloneWithType&type=Code
    https://github.com/search?l=Java&q=org%3Aballerina-platform+FromJsonWithType&type=Code

  2. Need to enable tests disabled by Fix and disable some service dispatching tests module-ballerina-http#1409

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@Nadeeshan96 Nadeeshan96 self-assigned this Jan 13, 2023
@Nadeeshan96 Nadeeshan96 moved this to In Progress in Ballerina Team Main Board Apr 7, 2023
@Nadeeshan96 Nadeeshan96 moved this from In Progress to PR Sent in Ballerina Team Main Board Apr 11, 2023
@Nadeeshan96
Copy link
Author

Closing the issue since the task is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment