Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use convert API instead of cloneWithType #974

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

Nadeeshan96
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 commented Apr 7, 2023

Purpose

Partially fixes the issue ballerina-platform/ballerina-library#3933

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.09 ⚠️

Comparison is base (64ef567) 82.70% compared to head (f620628) 82.61%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #974      +/-   ##
============================================
- Coverage     82.70%   82.61%   -0.09%     
  Complexity      548      548              
============================================
  Files            50       50              
  Lines          3018     3020       +2     
  Branches        490      490              
============================================
- Hits           2496     2495       -1     
- Misses          379      381       +2     
- Partials        143      144       +1     
Impacted Files Coverage Δ
...t/client/listener/SyncClientConnectorListener.java 81.97% <71.42%> (-0.87%) ⬇️
.../stdlib/websocket/WebSocketResourceDispatcher.java 83.73% <100.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review April 7, 2023 11:30
@Bhashinee Bhashinee merged commit 75d4594 into ballerina-platform:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants