Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use convert API and enable disabled tests #1545

Merged

Conversation

Nadeeshan96
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 commented Apr 7, 2023

Purpose

$title
Partially fixes the issue ballerina-platform/ballerina-library#3933

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.04 ⚠️

Comparison is base (4f51feb) 81.60% compared to head (b63cfd7) 81.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1545      +/-   ##
============================================
- Coverage     81.60%   81.57%   -0.04%     
  Complexity      524      524              
============================================
  Files           388      388              
  Lines         21064    21060       -4     
  Branches       4702     4700       -2     
============================================
- Hits          17189    17179      -10     
- Misses         2892     2898       +6     
  Partials        983      983              
Impacted Files Coverage Δ
.../stdlib/http/api/service/signature/ParamUtils.java 83.87% <50.00%> (ø)
...lib/http/api/service/signature/AllQueryParams.java 90.76% <100.00%> (-0.28%) ⬇️
.../service/signature/builder/JsonPayloadBuilder.java 90.90% <100.00%> (-1.40%) ⬇️
...ice/signature/converter/JsonToRecordConverter.java 64.70% <100.00%> (-11.77%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review April 10, 2023 13:11
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TharmiganK TharmiganK merged commit 81a4688 into ballerina-platform:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants