Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use convert API instead of CloneWithType #70

Merged
merged 9 commits into from
May 18, 2023

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Partially fixes the issue ballerina-platform/ballerina-library#3933

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.00 🎉

Comparison is base (d9efca4) 87.46% compared to head (60538c1) 88.47%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
+ Coverage     87.46%   88.47%   +1.00%     
- Complexity      176      253      +77     
============================================
  Files            20       36      +16     
  Lines           367      538     +171     
  Branches         66       91      +25     
============================================
+ Hits            321      476     +155     
- Misses           29       36       +7     
- Partials         17       26       +9     
Impacted Files Coverage Δ
...va/io/ballerina/stdlib/constraint/Constraints.java 73.13% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review April 10, 2023 10:45
gradle.properties Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 4, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 4, 2023
@Nadeeshan96 Nadeeshan96 removed the Stale label May 5, 2023
TharmiganK
TharmiganK previously approved these changes May 18, 2023
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TharmiganK TharmiganK merged commit 2681a7b into ballerina-platform:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants