Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and disable some service dispatching tests #1409

Merged

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

$title

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@Nadeeshan96
Copy link
Contributor Author

Created ballerina-platform/ballerina-library#3933 for enabling the disabled tests.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 81.02% // Head: 81.04% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c0816f5) compared to base (f73462c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files         362      362              
  Lines       19639    19639              
  Branches     4323     4323              
==========================================
+ Hits        15913    15916       +3     
+ Misses       2868     2866       -2     
+ Partials      858      857       -1     
Impacted Files Coverage Δ
...ransport/message/DefaultFullHttpMessageFuture.java 100.00% <0.00%> (+4.00%) ⬆️
...ctimpl/sender/states/http2/EntityBodyReceived.java 46.42% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Krishnananthalingam Tharmigan <[email protected]>
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases were failing due to databinding error because of this bug in lang. We may have to write negative tests cases for this after that lang bug is fixed.

@TharmiganK TharmiganK merged commit faeab08 into ballerina-platform:master Jan 13, 2023
@Nadeeshan96 Nadeeshan96 deleted the master-fix-dispatching-tests branch January 20, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants