Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittently failing unit test and allows running individual unit test files #1141

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

LiuJoyceC
Copy link
Contributor

Increases timeout on unit test that intermittently failed due to server timeout.Also adds an npm script to allow running only specified unit test files. To use it, simply run npm run testfiles [names of unit tests files/directories separated by space]. For example, running npm run testfiles test/request.spec.coffee test/services will run only the unit tests in the test/request.spec.coffee file and the toplevel files in the directory test/services. Works only with NPM version 2 or higher.

/cc: @chrisradek

…er timeout.Also adds an npm script to allow running only specified unit test files. To use it, simply run `npm run testfiles [names of unit tests files/directories separated by space]`. For example, running `npm run testfiles test/request.spec.coffee test/services` will run only the unit tests in the test/request.spec.coffee file and the toplevel files in the directory test/services. Works only with NPM version 2 or higher.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.198% when pulling f0deb25 on LiuJoyceC:fixIntermittentTemporalTestFailure into 5a26680 on aws:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage remained the same at 90.198% when pulling f0deb25 on LiuJoyceC:fixIntermittentTemporalTestFailure into 5a26680 on aws:master.

@@ -72,6 +72,7 @@
"buildertest": "mocha --compilers coffee:coffee-script -s 1000 -t 10000 dist-tools/test",
"integration": "cucumber.js",
"lint" : "eslint lib dist-tools/*.js",
"console": "./scripts/console"
"console": "./scripts/console",
"testfiles" : "istanbul `[ $COVERAGE ] && echo 'cover _mocha' || echo 'test mocha'`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added an extra script into package.json.

@chrisradek
Copy link
Contributor

:shipit:

@LiuJoyceC LiuJoyceC merged commit f434347 into aws:master Sep 20, 2016
chrisradek added a commit that referenced this pull request Sep 20, 2016
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants