Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS S3 upload failed: TypeError: punycode.toASCII is not a function #1148

Closed
MaxVita opened this issue Sep 19, 2016 · 3 comments · Fixed by #1149
Closed

AWS S3 upload failed: TypeError: punycode.toASCII is not a function #1148

MaxVita opened this issue Sep 19, 2016 · 3 comments · Fixed by #1149

Comments

@MaxVita
Copy link

MaxVita commented Sep 19, 2016 •
edited
Loading

Hi,

i got an "old" error in the 2.6.3 sdk version if i try to upload something in our requirejs environment.

Please see #999

Thank you.
@LiuJoyceC
Copy link
Contributor

Hi @MaxVita
So according to the other issue, version 2.5.6 works, but you start getting this error in 2.6.0 and above? Or does it only start failing with 2.6.3? The version of browserify that the SDK uses was updated in 2.6.0. I'll investigate to see why it's causing this error. Thanks.

@chrisradek chrisradek added Bug and removed Question labels Sep 19, 2016
chrisradek added a commit that referenced this issue Sep 19, 2016
@chrisradek
Updates url and querystring dependencies for the browser version of t…
7c0d164 
…he SDK.

Previously, relied on tools like webpack/browserify to see these native node modules and supply a 3rd party library version.

This caused an issue with some versions of the url library breaking in projects that used AMD for module loading.

Fixes #1148
@chrisradek chrisradek mentioned this issue Sep 19, 2016
Merged
@MaxVita
Copy link
Author

MaxVita commented Sep 20, 2016

Hey @LiuJoyceC

2.5.6 works well and all versions >2.5.6 (2.6.0 and above) will fail with "TypeError: punycode.toASCII is not a function".

chrisradek added a commit that referenced this issue Sep 20, 2016
@chrisradek
Tag release v2.6.4
513bdeb 
References:
  #1139, #1140, #1141, #1144, #1148, #1149
@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates url and querystring dependencies for the browser version of the SDK aws/aws-sdk-js
3 participants
@LiuJoyceC @chrisradek @MaxVita