Fixes issue with service-bound global config #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig.update would silently fail by default unless allowUnknownKeys was specified. Fixes #1139
|
I like these changes. In addition to fixing the bug, it also now lazy loads service API models even when you directly require an individual service, which is consistent with how it was done before version 2.6.0, and consistent with how models are loaded when all services are required. Even better, now it only loads the model for a specific version. 🚀 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where passing service specific configuration into AWS.config.update would silently fail by default unless allowUnknownKeys was specified.
Previously, service clients were only built when the client (i.e.
AWS.S3) was accessed. Now, service clients will be built on initial load, but the api models won't be loaded until the client is instantiated.Fixes #1139
//cc: @LiuJoyceC