Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bugs in documentation tool #1140

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Fixes bugs in documentation tool #1140

merged 1 commit into from
Sep 19, 2016

Conversation

LiuJoyceC
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.198% when pulling 56f7c19 on LiuJoyceC:yardocDebug into 4c76853 on aws:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 90.198% when pulling 56f7c19 on LiuJoyceC:yardocDebug into 4c76853 on aws:master.

chrisradek
chrisradek approved these changes Sep 19, 2016
View reviewed changes
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me for examples. Do you know if we'll have issues when we have multiple, different versions of paginators/waiters for a specific service? I noticed we weren't passing a version in for those methods.

@LiuJoyceC
Copy link
Contributor Author

The waiters are already pulling in the specific version (see line 259 of plugin.rb). The paginators.json files aren't used in our docs (instead, we rely on documentation from service teams about their service-specific paginator-related params (such as NextToken, MaxKeys, etc.))

@chrisradek
Copy link
Contributor

Gotcha, thanks for the info!
:shipit:

@LiuJoyceC LiuJoyceC merged commit 87d6400 into aws:master Sep 19, 2016
chrisradek added a commit that referenced this pull request Sep 20, 2016
@chrisradek
Tag release v2.6.4
513bdeb 
References:
  #1139, #1140, #1141, #1144, #1148, #1149
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisradek chrisradek chrisradek approved these changes

Assignees

@chrisradek chrisradek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LiuJoyceC @coveralls @chrisradek @srchase @awsdave