Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): use root TSConfigs #3151

Closed
wants to merge 6 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2022

Issue

Refs: #1307
Replaces: #3132

Description

Uses common TSConfig for all generated clients

Testing

CI

Additional context

Cleaned up version of #3149


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: rename tsconfig.json to tsconfig.cjs.json feat: use common TSConfig for clients Jan 6, 2022
@trivikr trivikr changed the title feat: use common TSConfig for clients feat(clients): use root TSConfig Jan 6, 2022
@trivikr trivikr marked this pull request as ready for review January 6, 2022 05:20
@trivikr trivikr requested a review from a team as a code owner January 6, 2022 05:20
@trivikr trivikr changed the title feat(clients): use root TSConfig feat(clients): use root TSConfigs Jan 6, 2022
@trivikr
Copy link
Member Author

trivikr commented Jan 6, 2022

Moving to draft as issues with TSServer in VSCode and docs generation are being discussed in WIP PR #3149

foreach parentDir ("clients" "private")
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/tsconfig.json/tsconfig.cjs.json/g' ./package.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && mv tsconfig.json tsconfig.cjs.json); done
end
foreach parentDir ("clients" "private")
  foreach tsConfigType ("cjs" "es" "types")
    for dir in ./$parentDir/*; do (
      cd "$dir"
      cp ../../clients/client-accessanalyzer/tsconfig.$tsConfigType.json tsconfig.$tsConfigType.json
    ); done
  end
end
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant