-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): use root TSConfigs #3151
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
chore: rename tsconfig.json to tsconfig.cjs.json
feat: use common TSConfig for clients
Jan 6, 2022
trivikr
changed the title
feat: use common TSConfig for clients
feat(clients): use root TSConfig
Jan 6, 2022
trivikr
changed the title
feat(clients): use root TSConfig
feat(clients): use root TSConfigs
Jan 6, 2022
Moving to draft as issues with TSServer in VSCode and docs generation are being discussed in WIP PR #3149 |
This was referenced Jan 6, 2022
foreach parentDir ("clients" "private") for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/tsconfig.json/tsconfig.cjs.json/g' ./package.json); done for dir in ./$parentDir/*; do (cd "$dir" && mv tsconfig.json tsconfig.cjs.json); done end
foreach parentDir ("clients" "private") foreach tsConfigType ("cjs" "es" "types") for dir in ./$parentDir/*; do ( cd "$dir" cp ../../clients/client-accessanalyzer/tsconfig.$tsConfigType.json tsconfig.$tsConfigType.json ); done end end
trivikr
force-pushed
the
root-tsconfig-clients
branch
from
January 7, 2022 19:18
ed442bc
to
b8978be
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #1307
Replaces: #3132
Description
Uses common TSConfig for all generated clients
Testing
CI
Additional context
Cleaned up version of #3149
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.