Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest): remove unused configuration #3160

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 7, 2022

Issue

Improvement noticed while working on root TSConfigs in #3151

Description

Removes unused configuration from jest.config.js and jest.config.integ.js
The jest.config.js uses projects configuration to specify which packages should run jest, and doesn't run the test in <rootDir>. Rest of the configuration is not used.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(jest): run jest in CI without type checking chore(jest): remove unused configuration Jan 7, 2022
@trivikr trivikr marked this pull request as ready for review January 7, 2022 16:38
@trivikr trivikr requested a review from a team as a code owner January 7, 2022 16:38
@trivikr trivikr merged commit 3fbbab2 into aws:main Jan 7, 2022
@trivikr trivikr deleted the jest-config-cleanup branch January 7, 2022 17:10
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants