Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): update tsconfig files while copying clients #3152

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2022

Issue

Codegen for #3151

Description

Add script to update tsconfig files copying clients

Testing

Verified with client-acm that:

  • The occurrences of tsconfig.json are replaced with tsconfig.cjs.json
  • The tsconfig files are copied correctly

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 6, 2022 05:22
@trivikr trivikr changed the title feat(scripts): add script to update tsconfig files copying clients feat(scripts): update tsconfig files while copying clients Jan 6, 2022
@trivikr
Copy link
Member Author

trivikr commented Jan 6, 2022

Moving to draft as we're facing issues with docs generation and TSServer in VSCode as described in the comments of WIP PR #3149

@trivikr trivikr marked this pull request as draft January 6, 2022 16:26
@trivikr trivikr closed this Jan 24, 2022
@trivikr trivikr deleted the generate-clients-tsconfig branch January 24, 2022 20:14
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant