-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore tsconfig provided by smithy-typescript, and extend root TSConfig while running generate-clients
#1307
Comments
Closed by mistake. smithy-typescript will emit a separate TSConfig, as clients should be able to work on their own in an independent repository. The ask is to use central TSConfig in aws-sdk-js-v3 monorepo. |
This comment has been minimized.
This comment has been minimized.
Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Is your feature request related to a problem? Please describe.
The PR #1297 creates root TSConfig for
packages/*
, but it doesn't apply toclients/*
as the clients generated by smithy-typescript should be able to work independently. They need not be part of a monorepo setup.Because of this, the internal dependencies are not navigable in clients as shown in the screenshot
Screenshot
Describe the solution you'd like
Let smithy-typescript emit tsconfig as it wants, but it should be overriden to extend root TSConfig by
generate-clients
command.Describe alternatives you've considered
Sticking with individual TSConfig files for clients
The text was updated successfully, but these errors were encountered: