-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(scripts): remove devDeps defined in monorepo root #3138
chore(scripts): remove devDeps defined in monorepo root #3138
Conversation
Moving to draft till release automation moves to using |
Codecov Report
@@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 474 474
Lines 20721 20721
Branches 4755 4755
=======================================
Hits 15581 15581
Misses 5140 5140 Continue to review full report at Codecov.
|
@@ -35,6 +35,11 @@ const mergeManifest = (fromContent = {}, toContent = {}) => { | |||
const merged = {}; | |||
for (const name of Object.keys(fromContent)) { | |||
if (fromContent[name].constructor.name === "Object") { | |||
if (name === "devDependencies") { | |||
// Remove devDeps defined in monorepo root | |||
const devDepsInRoot = ["downlevel-dts", "rimraf", "typedoc", "typescript"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if we can also remove the @aws-sdk/service-client-documentation-generator
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to remove @aws-sdk/service-client-documentation-generator
if it's defined in root package.json
We can take it up in a separate PR as it's an internal dependency and will need additional testing with docs generation.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Related to using root tsconfig for all clients in aws-sdk-js-v3
Refs: #1307
Description
Removes devDeps defined in monorepo root from clients.
Individual devDeps, if present, were removed in #3139
Testing
Testing that the packages work without dependencies is done in #3139
Verified that dependencies are not added during client generation with client-acm:
Additional context
Discussion in lerna lerna/lerna#1079
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.