[AD-721] resolve linux build error #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy§ion=all . The fix would be changing it back to ubuntu-20.04 * for more details, see ZedThree/clang-tidy-review#36
* update to newest release: ZedThree/[email protected]
* revert back to 20.04. This is an attempt to resolve the build errors
….com/aws/amazon-documentdb-odbc-driver into alinaliBQ/AD-721/resolve_check_error
* since we moved clang-tidy to somewhere else, checks.yml is no longer needed
affonsov
approved these changes
Apr 27, 2022
I thought clang-tidy only looks at the changed files in the PR, which does not include any files in the actual code, just the yml files. The base directory seems correct to me so I think it should be good. I'll double check |
affonsov
reviewed
Apr 28, 2022
|
Clang-tidy-check is not working perfectly (not finding some .h files in here). I will need to create a compile_commands.json file for it. |
birschick-bq
approved these changes
Apr 28, 2022
* compile_commands.json is needed for clang to correctly find macros and .h files
* add Jira ticket reference for TODO
alinaliBQ
added a commit
that referenced
this pull request
Apr 29, 2022
This reverts commit 0249517.
affonsov
pushed a commit
that referenced
this pull request
Nov 16, 2022
* throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult
affonsov
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Bug fix, support long type for aggregation (#522) * Bug fix, support long type for aggregation * change to datetime to JDBC format * Opendistro Release 1.9.0 (#532) * prepare odfe 1.9 * Fix all ES 7.8 compile and build errors * Revert changes as Lombok is working now * Update CustomExternalTestCluster.java * Fix license headers check * Use splitFieldsByMetadata to separate fields when calling SearchHit constructor * More fixes for ODFE 1.9 * Remove todo statement * Add ODFE 1.9.0 release notes * Rename release notes to use 4 digit versions (#547) * Revert changes ahead of develop branch in master (#551) * Revert "Rename release notes to use 4 digit versions (#547)" This reverts commit 33c6d3e37691e40c19d7d5892318e7ad23a82def. * Revert "Opendistro Release 1.9.0 (#532)" This reverts commit 254f2e0a854ba2c05aca159a9f7ff9af9867c22c. * Revert "Bug fix, support long type for aggregation (#522)" This reverts commit fb2ed912c8bfe50abed8fba182f2125905220cb4. * Merge all SQL repos and adjust workflows (#549) (#554) * merge all sql repos * fix test and build workflows * fix workbench and odbc path * fix workbench and odbc path * restructure workbench dir and fix workflows * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * revert workbench directory structure * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * update workbench workflow for release * Delete .github/ in sql-workbench directory * Add cypress to sql-workbench * Sync latest ODBC commits * Sync latest workbench commits (will add cypress in separate PR) * Add ignored ODBC libs * add date and time support (#560) * add date and time support * update doc * update doc * Revert "add date and time support (#560)" (#567) This reverts commit 4b33a2ff54f288c1a2bd07911062ec5943e3fe00. * add error details for all server communication errors (#645) - add null check to avoid crashing if details not initialized * Revert "add error details for all server communication errors (#645)" (#653) This reverts commit c11125d752fdd5554608de170a3688dcd4ad544c. * Fix download link in package description (#729) * Change SQL plugin version from 1.11.0.1 to 1.11.0.0 (#789) * Adding example of nested() for more complex nested queries (#799) * Revert "Adding example of nested() for more complex nested queries (#799)" (#800) This reverts commit aa115cc296301025189cfa6e6a76e06fa43631a2. * Release/0.3.0 (#82) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Yan Wang <[email protected]> Co-authored-by: Jerry Leung <[email protected]> * Release/0.4.0 (#102) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp * Update README.md (#85) Added information for compiling in Visual Studio. * At 735 Improve test cases for SQLGetDescField (#83) * revise error message * improve tests for SQLGetDescField * add assertion on return value for SQLGetDescField * uncomment test cases * add Kyle to reviewers * revise SQLGetTypeInfo tests * simplify type conversion test cases * simplify result integration tests * fix win32 build issue, remove unused tests from elasticsearch * refactor SQLBindCol test to remove duplicate code * adjust oridinal position for SQLColumns (#90) * [1] Initial commit for linux support for timestream * [1] Adding linux build workflow. * [1] Minor updates * [1] Fixing compielr error * [1] Fixing pointer * [1] Corrected last couple tests. * [1] Adjusting string for compiler error * [1] Fixing mac string cppcheck issue * [1] Fixing additional plus sign * [1] Fixing test failure * [1] Updates from PR feedback * [1] Small fixes for code review. * AT 620 - Plus sign not working in connection options (#88) * Fix connection string corrupted in Test Setup * fix Fixture::Setup() corrupted connection string by switching std::string to std::wstring, remove percent encoding/decoding from ODBC layer, add percent encoding in AAD, use JsonValue to build Okta request body * remove FORCE_PASSWORDE_DISPLAY so that passwords are always hidden, fix logging passwords in utf8_to_ucs2_lf * improve github actions * remove curly braces from log output in connection string * add back curly braces in connection string and test in github actions * add printf to debug * add back removing curly in connection string * revert change in main.yml * use macro on esNAME type * remove unused decoding function * update comment * add case insentitive substring match on key of connection string * [1] Checking linux segfaults * [1] Increasing output. * [1] Adding some code for debugging * [1] More debug info * [1] Enabling all tests for test_odbc_results.cpp * [1] Minor debug updates. * [1] flist printf fix. * [1] Checking user/secret updates * [1] Fixing cppcheck * [1] 32 bit enabled. * [1] trying 32 bit hack for build. * [1] Adjusting linux script. * [1] Trying to fix toolchaiun for aws. * [1] Trying to force cmake lookup * [1] trying to remove find root * [1] Updating target properties. * no message * no message * no message * no message * Fix portability problems - Fix conflict with version.h on some OSes. - Reduce warnings about mylog.h due to ES_PRINTF_ATTRIBUTE. * no message * [1] Trying to force i386 toolchain * [1] Trying to move constants * [1] Removing printf * [1] Checking if it is on destruction that I am segfaulting. * [1] Adding additional define for linux * minor release with bug fixed (#93) * [1] Fixing warnings * [1] Fixing test issue and warnings * [1] Adding quote * [1] More fixes * [1] Testing fix for pragmas * [1] General cleanup done across the board for tests and driver * [1] Minor ifdef updates * [1] fixing pragmas * [1] Fixing build error. * [1] More missing semicolons * [1] Fixing more warnings * [1] Fixing some more warnings * [1] Fixing else * [1] Eliminating more warnings * [1] Adjusting pragmas * [1] Fixing pragmas * [`] More minor fixes * [1] Macro fixes * [1] Removing prafgmas that aren t working * Remove including qresult.h when not necessary Don't include qresult.h in header when not needed. * AT-800: Release row buffers as rows are consumed * Rework SQLBindCol tests to allow fetch size Modify the way SQLBindCol is used to properly allow binding of multiple rows of SQL_C_CHAR data. Fix incorrect binding of SQLLEN data that can cause a crash Add a multirow-fetch test. * [1] Added Linux build instructions. * [1] Removing outdated comment. * [1] Lowering log level to debug. * [1] Fixing linux compiler errors. * [1] Enabling DSN tests * [1] Removed outdated 32-bit/64-bit bin/lib references * [1] Adding some prints to dlg_specific.c * [1] Minor fix for dsn. * [1] Trying a different dsn fix. * [1] Adding some debug printouts * [1] Fixing build script. * [1] Updates based on PR feedback. * [1] DSN Debugging * [1] ls fix. * [1] More command fixes. * Revert "adjust oridinal position for SQLColumns (#90)" This reverts commit 6d3746f. * [1] Trying etc based build. * [1] Fixing cat print. * Revert "adjust oridinal position for SQLColumns (#90)" (#96) This reverts commit 6d3746f. * [1] Minor updqtes yml to tryt to debug. * [1] Removing mkdir * [1] Fixing 32-bit dsn. * [1] Fixing build script and trying to adjust misc.h * [1] Fixed a bunch of warnings. [2] adjusted output of installer. * [1] Fixed a bunch more warnings and build error. * [1] More warning fixes and also enable Werror * [1] Removing another warning * [1] Reverting removal and fixing warning with pragma because windows build needs it. * [1] Fixing cppcheck error and pedantic error * [1] more cppcheck fixes * no message * [1] Removing more unused functions and macros. * [1] Removing printouts * [1] fixing more warnings * [1] Trying to fix warning. * [1] Fixing linker * [1] Trying to fix installer upload * [1] Fixing build script * [1] Fixing 32-bit failure and adding test for sample app [2] Updating readme because it was kind of weird * [1] Retrying cli build but moving so it is fail fast. * [1] cd fix and readme updates. * [1] Minor cli updates. * [1] Added additional debug info * [1] Printing errors to see if it will help debug issue with ODBCcli * [1]\ Minor fixes * [1] Fixing brace * [1] More updates * [1] Install deb so sample app can be tested. * [1] Fixiong cppcheck * [1] Updates to debug issue * no message * no message * no message * no message * no message * no message * no message * final test * [1] Bug fixes. * [1] Removing printf spam. [2] Fixing other issues * [1] Fixed encoding. * [1] Fixing query * [1] Fixing bitwise manips [2] Removing sample app from build script because it now works properly. * [1] Meant to remove this in the last commit.. * [1] Minor fixes for CR. * Update CHANGELOG.md * AT-748/803 Add more test cases (#98) * remove some es prefixes * remove es prefixes * remove more es prefixes * remove prefixes * return false for deprecated functions * add test cases for SQLForeignKeys, SQLPrimaryKeys * add test cases for remaining catalog functions * add test cases for unsupported functions * address review comments, remove more es prefixes, rename overloading functions * add impl and a test case for SQLTransact * use static_cast * add -fPIC compiler option * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md * Release/0.4.0 (#100) * Update CHANGELOG.md * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md Co-authored-by: Charlene Solonynka <[email protected]> * add one more keyword that needs to be masked (#101) * add one more keyword that needs to be masked * improve hide_password() Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: Joshua <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Jordan Wilson <[email protected]> Co-authored-by: Chloe <[email protected]> Co-authored-by: chloe-zh <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Francesco Capponi <[email protected]> Co-authored-by: Chen Dai <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]>
affonsov
pushed a commit
that referenced
this pull request
Nov 16, 2022
* [AD-721] resolve build error * reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy§ion=all . The fix would be changing it back to ubuntu-20.04 * for more details, see ZedThree/clang-tidy-review#36 * [AD-721] updating PR template * [AD-721] update checks.yml * update to newest release: ZedThree/[email protected] * [AD-721] change ubuntu version in docker file * [AD-721] change ubuntu version in docker file * revert back to 20.04. This is an attempt to resolve the build errors * [AD-721] move clang check to linux build * [AD-721] fix linux-build.yml * [AD-721] remove checks.yml * since we moved clang-tidy to somewhere else, checks.yml is no longer needed * [AD-721] move clang-check after cppcheck * [AD-721] generate compile_commands.json * compile_commands.json is needed for clang to correctly find macros and .h files * [AD-721] attempt to fix clang-tidy cmake command error * [AD-721] upload pre-generated compile_commands.json for clang-tidy * [AD-721] temporarily disable cmake_command in clang-tidy-review * [AD-721] remove clang-tidy check * add Jira ticket reference for enabling clang-tidy check (TODO)
affonsov
pushed a commit
that referenced
this pull request
Nov 17, 2022
* throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult
affonsov
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Bug fix, support long type for aggregation (#522) * Bug fix, support long type for aggregation * change to datetime to JDBC format * Opendistro Release 1.9.0 (#532) * prepare odfe 1.9 * Fix all ES 7.8 compile and build errors * Revert changes as Lombok is working now * Update CustomExternalTestCluster.java * Fix license headers check * Use splitFieldsByMetadata to separate fields when calling SearchHit constructor * More fixes for ODFE 1.9 * Remove todo statement * Add ODFE 1.9.0 release notes * Rename release notes to use 4 digit versions (#547) * Revert changes ahead of develop branch in master (#551) * Revert "Rename release notes to use 4 digit versions (#547)" This reverts commit 33c6d3e37691e40c19d7d5892318e7ad23a82def. * Revert "Opendistro Release 1.9.0 (#532)" This reverts commit 254f2e0a854ba2c05aca159a9f7ff9af9867c22c. * Revert "Bug fix, support long type for aggregation (#522)" This reverts commit fb2ed912c8bfe50abed8fba182f2125905220cb4. * Merge all SQL repos and adjust workflows (#549) (#554) * merge all sql repos * fix test and build workflows * fix workbench and odbc path * fix workbench and odbc path * restructure workbench dir and fix workflows * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * revert workbench directory structure * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * update workbench workflow for release * Delete .github/ in sql-workbench directory * Add cypress to sql-workbench * Sync latest ODBC commits * Sync latest workbench commits (will add cypress in separate PR) * Add ignored ODBC libs * add date and time support (#560) * add date and time support * update doc * update doc * Revert "add date and time support (#560)" (#567) This reverts commit 4b33a2ff54f288c1a2bd07911062ec5943e3fe00. * add error details for all server communication errors (#645) - add null check to avoid crashing if details not initialized * Revert "add error details for all server communication errors (#645)" (#653) This reverts commit c11125d752fdd5554608de170a3688dcd4ad544c. * Fix download link in package description (#729) * Change SQL plugin version from 1.11.0.1 to 1.11.0.0 (#789) * Adding example of nested() for more complex nested queries (#799) * Revert "Adding example of nested() for more complex nested queries (#799)" (#800) This reverts commit aa115cc296301025189cfa6e6a76e06fa43631a2. * Release/0.3.0 (#82) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Yan Wang <[email protected]> Co-authored-by: Jerry Leung <[email protected]> * Release/0.4.0 (#102) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp * Update README.md (#85) Added information for compiling in Visual Studio. * At 735 Improve test cases for SQLGetDescField (#83) * revise error message * improve tests for SQLGetDescField * add assertion on return value for SQLGetDescField * uncomment test cases * add Kyle to reviewers * revise SQLGetTypeInfo tests * simplify type conversion test cases * simplify result integration tests * fix win32 build issue, remove unused tests from elasticsearch * refactor SQLBindCol test to remove duplicate code * adjust oridinal position for SQLColumns (#90) * [1] Initial commit for linux support for timestream * [1] Adding linux build workflow. * [1] Minor updates * [1] Fixing compielr error * [1] Fixing pointer * [1] Corrected last couple tests. * [1] Adjusting string for compiler error * [1] Fixing mac string cppcheck issue * [1] Fixing additional plus sign * [1] Fixing test failure * [1] Updates from PR feedback * [1] Small fixes for code review. * AT 620 - Plus sign not working in connection options (#88) * Fix connection string corrupted in Test Setup * fix Fixture::Setup() corrupted connection string by switching std::string to std::wstring, remove percent encoding/decoding from ODBC layer, add percent encoding in AAD, use JsonValue to build Okta request body * remove FORCE_PASSWORDE_DISPLAY so that passwords are always hidden, fix logging passwords in utf8_to_ucs2_lf * improve github actions * remove curly braces from log output in connection string * add back curly braces in connection string and test in github actions * add printf to debug * add back removing curly in connection string * revert change in main.yml * use macro on esNAME type * remove unused decoding function * update comment * add case insentitive substring match on key of connection string * [1] Checking linux segfaults * [1] Increasing output. * [1] Adding some code for debugging * [1] More debug info * [1] Enabling all tests for test_odbc_results.cpp * [1] Minor debug updates. * [1] flist printf fix. * [1] Checking user/secret updates * [1] Fixing cppcheck * [1] 32 bit enabled. * [1] trying 32 bit hack for build. * [1] Adjusting linux script. * [1] Trying to fix toolchaiun for aws. * [1] Trying to force cmake lookup * [1] trying to remove find root * [1] Updating target properties. * no message * no message * no message * no message * Fix portability problems - Fix conflict with version.h on some OSes. - Reduce warnings about mylog.h due to ES_PRINTF_ATTRIBUTE. * no message * [1] Trying to force i386 toolchain * [1] Trying to move constants * [1] Removing printf * [1] Checking if it is on destruction that I am segfaulting. * [1] Adding additional define for linux * minor release with bug fixed (#93) * [1] Fixing warnings * [1] Fixing test issue and warnings * [1] Adding quote * [1] More fixes * [1] Testing fix for pragmas * [1] General cleanup done across the board for tests and driver * [1] Minor ifdef updates * [1] fixing pragmas * [1] Fixing build error. * [1] More missing semicolons * [1] Fixing more warnings * [1] Fixing some more warnings * [1] Fixing else * [1] Eliminating more warnings * [1] Adjusting pragmas * [1] Fixing pragmas * [`] More minor fixes * [1] Macro fixes * [1] Removing prafgmas that aren t working * Remove including qresult.h when not necessary Don't include qresult.h in header when not needed. * AT-800: Release row buffers as rows are consumed * Rework SQLBindCol tests to allow fetch size Modify the way SQLBindCol is used to properly allow binding of multiple rows of SQL_C_CHAR data. Fix incorrect binding of SQLLEN data that can cause a crash Add a multirow-fetch test. * [1] Added Linux build instructions. * [1] Removing outdated comment. * [1] Lowering log level to debug. * [1] Fixing linux compiler errors. * [1] Enabling DSN tests * [1] Removed outdated 32-bit/64-bit bin/lib references * [1] Adding some prints to dlg_specific.c * [1] Minor fix for dsn. * [1] Trying a different dsn fix. * [1] Adding some debug printouts * [1] Fixing build script. * [1] Updates based on PR feedback. * [1] DSN Debugging * [1] ls fix. * [1] More command fixes. * Revert "adjust oridinal position for SQLColumns (#90)" This reverts commit 08caf34. * [1] Trying etc based build. * [1] Fixing cat print. * Revert "adjust oridinal position for SQLColumns (#90)" (#96) This reverts commit 08caf34. * [1] Minor updqtes yml to tryt to debug. * [1] Removing mkdir * [1] Fixing 32-bit dsn. * [1] Fixing build script and trying to adjust misc.h * [1] Fixed a bunch of warnings. [2] adjusted output of installer. * [1] Fixed a bunch more warnings and build error. * [1] More warning fixes and also enable Werror * [1] Removing another warning * [1] Reverting removal and fixing warning with pragma because windows build needs it. * [1] Fixing cppcheck error and pedantic error * [1] more cppcheck fixes * no message * [1] Removing more unused functions and macros. * [1] Removing printouts * [1] fixing more warnings * [1] Trying to fix warning. * [1] Fixing linker * [1] Trying to fix installer upload * [1] Fixing build script * [1] Fixing 32-bit failure and adding test for sample app [2] Updating readme because it was kind of weird * [1] Retrying cli build but moving so it is fail fast. * [1] cd fix and readme updates. * [1] Minor cli updates. * [1] Added additional debug info * [1] Printing errors to see if it will help debug issue with ODBCcli * [1]\ Minor fixes * [1] Fixing brace * [1] More updates * [1] Install deb so sample app can be tested. * [1] Fixiong cppcheck * [1] Updates to debug issue * no message * no message * no message * no message * no message * no message * no message * final test * [1] Bug fixes. * [1] Removing printf spam. [2] Fixing other issues * [1] Fixed encoding. * [1] Fixing query * [1] Fixing bitwise manips [2] Removing sample app from build script because it now works properly. * [1] Meant to remove this in the last commit.. * [1] Minor fixes for CR. * Update CHANGELOG.md * AT-748/803 Add more test cases (#98) * remove some es prefixes * remove es prefixes * remove more es prefixes * remove prefixes * return false for deprecated functions * add test cases for SQLForeignKeys, SQLPrimaryKeys * add test cases for remaining catalog functions * add test cases for unsupported functions * address review comments, remove more es prefixes, rename overloading functions * add impl and a test case for SQLTransact * use static_cast * add -fPIC compiler option * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md * Release/0.4.0 (#100) * Update CHANGELOG.md * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md Co-authored-by: Charlene Solonynka <[email protected]> * add one more keyword that needs to be masked (#101) * add one more keyword that needs to be masked * improve hide_password() Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: Joshua <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Jordan Wilson <[email protected]> Co-authored-by: Chloe <[email protected]> Co-authored-by: chloe-zh <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Francesco Capponi <[email protected]> Co-authored-by: Chen Dai <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]>
affonsov
pushed a commit
that referenced
this pull request
Nov 17, 2022
* [AD-721] resolve build error * reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy§ion=all . The fix would be changing it back to ubuntu-20.04 * for more details, see ZedThree/clang-tidy-review#36 * [AD-721] updating PR template * [AD-721] update checks.yml * update to newest release: ZedThree/[email protected] * [AD-721] change ubuntu version in docker file * [AD-721] change ubuntu version in docker file * revert back to 20.04. This is an attempt to resolve the build errors * [AD-721] move clang check to linux build * [AD-721] fix linux-build.yml * [AD-721] remove checks.yml * since we moved clang-tidy to somewhere else, checks.yml is no longer needed * [AD-721] move clang-check after cppcheck * [AD-721] generate compile_commands.json * compile_commands.json is needed for clang to correctly find macros and .h files * [AD-721] attempt to fix clang-tidy cmake command error * [AD-721] upload pre-generated compile_commands.json for clang-tidy * [AD-721] temporarily disable cmake_command in clang-tidy-review * [AD-721] remove clang-tidy check * add Jira ticket reference for enabling clang-tidy check (TODO)
alexey-temnikov
pushed a commit
that referenced
this pull request
Jan 14, 2023
* throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult
alexey-temnikov
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Bug fix, support long type for aggregation (#522) * Bug fix, support long type for aggregation * change to datetime to JDBC format * Opendistro Release 1.9.0 (#532) * prepare odfe 1.9 * Fix all ES 7.8 compile and build errors * Revert changes as Lombok is working now * Update CustomExternalTestCluster.java * Fix license headers check * Use splitFieldsByMetadata to separate fields when calling SearchHit constructor * More fixes for ODFE 1.9 * Remove todo statement * Add ODFE 1.9.0 release notes * Rename release notes to use 4 digit versions (#547) * Revert changes ahead of develop branch in master (#551) * Revert "Rename release notes to use 4 digit versions (#547)" This reverts commit 33c6d3e37691e40c19d7d5892318e7ad23a82def. * Revert "Opendistro Release 1.9.0 (#532)" This reverts commit 254f2e0a854ba2c05aca159a9f7ff9af9867c22c. * Revert "Bug fix, support long type for aggregation (#522)" This reverts commit fb2ed912c8bfe50abed8fba182f2125905220cb4. * Merge all SQL repos and adjust workflows (#549) (#554) * merge all sql repos * fix test and build workflows * fix workbench and odbc path * fix workbench and odbc path * restructure workbench dir and fix workflows * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * revert workbench directory structure * fix workbench workflow * fix workbench workflow * fix workbench workflow * fix workbench workflow * update workbench workflow for release * Delete .github/ in sql-workbench directory * Add cypress to sql-workbench * Sync latest ODBC commits * Sync latest workbench commits (will add cypress in separate PR) * Add ignored ODBC libs * add date and time support (#560) * add date and time support * update doc * update doc * Revert "add date and time support (#560)" (#567) This reverts commit 4b33a2ff54f288c1a2bd07911062ec5943e3fe00. * add error details for all server communication errors (#645) - add null check to avoid crashing if details not initialized * Revert "add error details for all server communication errors (#645)" (#653) This reverts commit c11125d752fdd5554608de170a3688dcd4ad544c. * Fix download link in package description (#729) * Change SQL plugin version from 1.11.0.1 to 1.11.0.0 (#789) * Adding example of nested() for more complex nested queries (#799) * Revert "Adding example of nested() for more complex nested queries (#799)" (#800) This reverts commit aa115cc296301025189cfa6e6a76e06fa43631a2. * Release/0.3.0 (#82) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Yan Wang <[email protected]> Co-authored-by: Jerry Leung <[email protected]> * Release/0.4.0 (#102) * AT 702 Metadata Support - Implement SQLTables (#49) Added support for SQLTables * AT-712 MetaData Support - Implement SQLGetInfo (#50) Add support for SQLGetInfo * At-707 - Implement SQLColumns (#51) * Basically works * Refactored and add more tests * Refactored code * Refactored * Refactored * Added more test cases * Fix macOS build errors * Fixed macOS build * basic structure for SQLColumns * remove redundant variable declaration * add integration tests for SQLColumns * fix incomparable type in ConvertPattern * address code review comments Co-authored-by: Jerry Leung <[email protected]> * AT-711 Metadata Support - Implement SQLGetTypeInfo (#52) * Basically working * Added integration test cases * Adjust test cases due to necessary change for excel * Adjust for macOS build * Removed commented code * Fixed build errors * Worked around execution not concurrent problem * Address review * Address code review * Update src/odfesqlodbc/es_info.cpp Co-authored-by: Yan Wang <[email protected]> * Address code review * Address code review * Fixed integration test cases * Update src/odfesqlodbc/es_types.c Co-authored-by: Yan Wang <[email protected]> * Address code revie Co-authored-by: Yan Wang <[email protected]> * At 706 - AAD support (#53) * get access token * add libcurl dependency * use http client inside aws sdk * AAD support * resolve base64 decoding issue * fix format * fix indentation * remove demo from cmake * revert format change * revert format fchange * make role arn available in AAD auth mode * Remove password log message (#55) * AT 749 - Improve performance of query execution (#54) * Added QueryAsync mechanism and updated related documentation * Manual Mac build (#58) * make mac build manually * add line break * At 742 Remove integration tests from ODBC Distribution (#57) * Removing VLD dependencies * AT-761 - Adjust catalog test cases for testing sample timestream database (#61) Adjust catalog test cases * AT-761 - Added integration test cases to test Amazon Timestream sample tables (#62) * Added integration test cases to test Amazon Timestream sample tables * At 772 Bump SDK version to 1.8.186 (#60) * bump aws sdk version to 1.9.19, and remove unrelated files * change aws sdk version from 1.9.19 to 1.8.186 to resolve compiler warning * use TS_ODBC_VERSION instead of hardcoing * remove re-definition * remove gibberish * AT-705 Okta authentication support (#56) * Okta support * uncomment the tests * fix build error in mac and win32 * refactor authentication * refactor AAD and Okta authentication into their own classes * add tests * add connection unit tests to github actions * remove use of SimpleAWSCredentialsProvider, just use AWSCredentials * resolve code review comments * make the parameter const reference for DecodeHex() * remove constness for value returned by c_str() * remove use of rabbit, use Aws::Utils::Json instead * Address review comments * remove demo files * address code reviews * make base64url encoding table a constant, and address nits * make some variables static const inline * use anonymous namespace instead of private static for some variables. * remove duplicate var definition * fix cppcheck warning * AT-770 get rid of rapidjson and rabbit (#63) * get rid of rapidjson and rabbit * add newline at the end of file * AT-704 Query cancel (#59) * Query cancel * AT-765 Refactor the connection function (#64) * Refactored connect functions into smaller functions * At 764 Add user agent for AWS client config (#65) * test getting application name in mac * get application name in windows * add user agent in client config * remove unused include * add log msg * add unit tests for GetUserAgent() * remove unused library folder variable in cmakelist (#66) * AT-774 throw an exception when scalar type not set or unsupported (#68) * throw an exception when scalar type not set or unsupported * use SC_set_error * add statement as parameter in SendQueryGetResult * change signature of _CC_(Metadata)_from_TSResult * AT-769 Code to limit size of the query (#67) * Added the size limit of queue * AT 763 Fix Debug build to test for Windows memory leaks (#70) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * AT-773/AT-775 - add comments for functions in es_parse_result.cpp (#69) * add comments for functions in es_parse_result.cpp * add extra line between function signatures * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md * Update BUILD_INSTRUCTIONS.md Removed extra "and" * AT-777 mask password (#74) * mask password * change Idp to IdP * Added ODBCcli tools * AT-818 Support Debug mode for Mac (#71) * Added support Debug mode for macOS * At 766 Refactor SQLPrepare to run metadata statement (#73) * Fixed for Win 64bits debug * Added github action for win debug * Enable memory leak detection in Visual Studio * remove TSResult struct and related functions * run metadata statement in SQLPrepare * refactor SendQueryGetResult and remove unneeded CC* functions * avoid extra strlen calls, and add a test case for SQLPrepare->SQLExecDirect * remove extra allocation/deallocation in API_Prepare, add test cases for SQLPrepare->SQLDescribeCol * remove commented code, call SC_initialize_and_recycle when returning SQL_ERROR Co-authored-by: Jerry Leung <[email protected]> * AT-819 - Integration test result log files are truncated (#76) * Resolve the x86 and x64 drivers and add registry for github actions * Fixed new line problem * Revised * Revised * Fixed Win32 reg * Test * test * Test * Fixed connection error log * Refactored * Fixed integration test cases * Renames files to remove ts_ and es_prefixes. * Changed ES_TYPE_CHAR to SQL_CHAR * Changed ES_TYPE to TS_TYPE * Renamed ES_ variables to TS_ * Removed commented code * Changes to parse_result for refactoring sqlPrepare * Address code review * Removed Semaphore files since they are no longer used. * Fixed macOS * Update README.md * Fix mac build (#79) * Fix * Added quotation mark * Update README.md * Update client.cpp Since the number of columns doesn't change per row, only call SQLNumResultCols if it isn't set. * Update CHANGELOG.md * Update CMakeLists.txt * Update helper.cpp * Update README.md (#85) Added information for compiling in Visual Studio. * At 735 Improve test cases for SQLGetDescField (#83) * revise error message * improve tests for SQLGetDescField * add assertion on return value for SQLGetDescField * uncomment test cases * add Kyle to reviewers * revise SQLGetTypeInfo tests * simplify type conversion test cases * simplify result integration tests * fix win32 build issue, remove unused tests from elasticsearch * refactor SQLBindCol test to remove duplicate code * adjust oridinal position for SQLColumns (#90) * [1] Initial commit for linux support for timestream * [1] Adding linux build workflow. * [1] Minor updates * [1] Fixing compielr error * [1] Fixing pointer * [1] Corrected last couple tests. * [1] Adjusting string for compiler error * [1] Fixing mac string cppcheck issue * [1] Fixing additional plus sign * [1] Fixing test failure * [1] Updates from PR feedback * [1] Small fixes for code review. * AT 620 - Plus sign not working in connection options (#88) * Fix connection string corrupted in Test Setup * fix Fixture::Setup() corrupted connection string by switching std::string to std::wstring, remove percent encoding/decoding from ODBC layer, add percent encoding in AAD, use JsonValue to build Okta request body * remove FORCE_PASSWORDE_DISPLAY so that passwords are always hidden, fix logging passwords in utf8_to_ucs2_lf * improve github actions * remove curly braces from log output in connection string * add back curly braces in connection string and test in github actions * add printf to debug * add back removing curly in connection string * revert change in main.yml * use macro on esNAME type * remove unused decoding function * update comment * add case insentitive substring match on key of connection string * [1] Checking linux segfaults * [1] Increasing output. * [1] Adding some code for debugging * [1] More debug info * [1] Enabling all tests for test_odbc_results.cpp * [1] Minor debug updates. * [1] flist printf fix. * [1] Checking user/secret updates * [1] Fixing cppcheck * [1] 32 bit enabled. * [1] trying 32 bit hack for build. * [1] Adjusting linux script. * [1] Trying to fix toolchaiun for aws. * [1] Trying to force cmake lookup * [1] trying to remove find root * [1] Updating target properties. * no message * no message * no message * no message * Fix portability problems - Fix conflict with version.h on some OSes. - Reduce warnings about mylog.h due to ES_PRINTF_ATTRIBUTE. * no message * [1] Trying to force i386 toolchain * [1] Trying to move constants * [1] Removing printf * [1] Checking if it is on destruction that I am segfaulting. * [1] Adding additional define for linux * minor release with bug fixed (#93) * [1] Fixing warnings * [1] Fixing test issue and warnings * [1] Adding quote * [1] More fixes * [1] Testing fix for pragmas * [1] General cleanup done across the board for tests and driver * [1] Minor ifdef updates * [1] fixing pragmas * [1] Fixing build error. * [1] More missing semicolons * [1] Fixing more warnings * [1] Fixing some more warnings * [1] Fixing else * [1] Eliminating more warnings * [1] Adjusting pragmas * [1] Fixing pragmas * [`] More minor fixes * [1] Macro fixes * [1] Removing prafgmas that aren t working * Remove including qresult.h when not necessary Don't include qresult.h in header when not needed. * AT-800: Release row buffers as rows are consumed * Rework SQLBindCol tests to allow fetch size Modify the way SQLBindCol is used to properly allow binding of multiple rows of SQL_C_CHAR data. Fix incorrect binding of SQLLEN data that can cause a crash Add a multirow-fetch test. * [1] Added Linux build instructions. * [1] Removing outdated comment. * [1] Lowering log level to debug. * [1] Fixing linux compiler errors. * [1] Enabling DSN tests * [1] Removed outdated 32-bit/64-bit bin/lib references * [1] Adding some prints to dlg_specific.c * [1] Minor fix for dsn. * [1] Trying a different dsn fix. * [1] Adding some debug printouts * [1] Fixing build script. * [1] Updates based on PR feedback. * [1] DSN Debugging * [1] ls fix. * [1] More command fixes. * Revert "adjust oridinal position for SQLColumns (#90)" This reverts commit 8efe672. * [1] Trying etc based build. * [1] Fixing cat print. * Revert "adjust oridinal position for SQLColumns (#90)" (#96) This reverts commit 8efe672. * [1] Minor updqtes yml to tryt to debug. * [1] Removing mkdir * [1] Fixing 32-bit dsn. * [1] Fixing build script and trying to adjust misc.h * [1] Fixed a bunch of warnings. [2] adjusted output of installer. * [1] Fixed a bunch more warnings and build error. * [1] More warning fixes and also enable Werror * [1] Removing another warning * [1] Reverting removal and fixing warning with pragma because windows build needs it. * [1] Fixing cppcheck error and pedantic error * [1] more cppcheck fixes * no message * [1] Removing more unused functions and macros. * [1] Removing printouts * [1] fixing more warnings * [1] Trying to fix warning. * [1] Fixing linker * [1] Trying to fix installer upload * [1] Fixing build script * [1] Fixing 32-bit failure and adding test for sample app [2] Updating readme because it was kind of weird * [1] Retrying cli build but moving so it is fail fast. * [1] cd fix and readme updates. * [1] Minor cli updates. * [1] Added additional debug info * [1] Printing errors to see if it will help debug issue with ODBCcli * [1]\ Minor fixes * [1] Fixing brace * [1] More updates * [1] Install deb so sample app can be tested. * [1] Fixiong cppcheck * [1] Updates to debug issue * no message * no message * no message * no message * no message * no message * no message * final test * [1] Bug fixes. * [1] Removing printf spam. [2] Fixing other issues * [1] Fixed encoding. * [1] Fixing query * [1] Fixing bitwise manips [2] Removing sample app from build script because it now works properly. * [1] Meant to remove this in the last commit.. * [1] Minor fixes for CR. * Update CHANGELOG.md * AT-748/803 Add more test cases (#98) * remove some es prefixes * remove es prefixes * remove more es prefixes * remove prefixes * return false for deprecated functions * add test cases for SQLForeignKeys, SQLPrimaryKeys * add test cases for remaining catalog functions * add test cases for unsupported functions * address review comments, remove more es prefixes, rename overloading functions * add impl and a test case for SQLTransact * use static_cast * add -fPIC compiler option * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md * Release/0.4.0 (#100) * Update CHANGELOG.md * Version Update Updated version to 0.4.0 and addressed comments in CHANGELOG.md Co-authored-by: Charlene Solonynka <[email protected]> * add one more keyword that needs to be masked (#101) * add one more keyword that needs to be masked * improve hide_password() Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: Joshua <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Jordan Wilson <[email protected]> Co-authored-by: Chloe <[email protected]> Co-authored-by: chloe-zh <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Francesco Capponi <[email protected]> Co-authored-by: Chen Dai <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: csolonynka <[email protected]> Co-authored-by: Jerry Leung <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: James Duong <[email protected]> Co-authored-by: Charlene Solonynka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the ubuntu version from ubuntu-latest to ubuntu-20.04 in checks.yml
Description
Related Issue
https://bitquill.atlassian.net/browse/AD-721
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq