Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AD-721] resolve linux build error #68

Merged
merged 15 commits into from
Apr 29, 2022
Merged

[AD-721] resolve linux build error #68

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9ee0264
[AD-721] resolve build error
alinaliBQ Apr 27, 2022
4e8e92f
[AD-721] updating PR template
alinaliBQ Apr 27, 2022
4c9e319
[AD-721] update checks.yml
alinaliBQ Apr 27, 2022
1bf3351
[AD-721] change ubuntu version in docker file
alinaliBQ Apr 27, 2022
c269c67
[AD-721] change ubuntu version in docker file
alinaliBQ Apr 27, 2022
bc816ce
Merge branch 'alinaliBQ/AD-721/resolve_check_error' of https://github…
alinaliBQ Apr 27, 2022
4f6d41d
[AD-721] move clang check to linux build
alinaliBQ Apr 27, 2022
0032790
[AD-721] fix linux-build.yml
alinaliBQ Apr 27, 2022
784de10
[AD-721] remove checks.yml
alinaliBQ Apr 27, 2022
a6ffb5c
[AD-721] move clang-check after cppcheck
alinaliBQ Apr 28, 2022
6da9203
[AD-721] generate compile_commands.json
alinaliBQ Apr 28, 2022
b1916e7
[AD-721] attempt to fix clang-tidy cmake command error
alinaliBQ Apr 28, 2022
a704f2d
[AD-721] upload pre-generated compile_commands.json for clang-tidy
alinaliBQ Apr 28, 2022
ab4be0f
[AD-721] temporarily disable cmake_command in clang-tidy-review
alinaliBQ Apr 28, 2022
24c4ae5
[AD-721] remove clang-tidy check
alinaliBQ Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
### Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
alinaliBQ marked this conversation as resolved.
Show resolved Hide resolved
@andiem-bq
@birschick-bq
<!-- Any additional reviewers -->
4 changes: 2 additions & 2 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ on: [pull_request]

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
alinaliBQ marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@v2
- uses: ZedThree/clang-tidy-review@v0.7.0
- uses: ZedThree/clang-tidy-review@v0.8.3
id: review
continue-on-error: true
7 changes: 7 additions & 0 deletions .github/workflows/linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ jobs:
check_name: "Ubuntu 20.04 Build Unit Test Results Check"
comment_title: "Ubuntu 20.04 Build Unit Test Results"
files: ./odbc_test_result.xml

birschick-bq marked this conversation as resolved.
Show resolved Hide resolved
- name: clang-tidy-check
alinaliBQ marked this conversation as resolved.
Show resolved Hide resolved
uses: ZedThree/[email protected]
id: review
# If there are any comments, fail the check
if: steps.review.outputs.total_comments > 0
run: exit 1

build-linux-docker-image:
runs-on: ubuntu-20.04
Expand Down
2 changes: 1 addition & 1 deletion docker/linux-environment/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:latest
FROM ubuntu:20.04

#set DEBIAN_FRONTEND=noninteractive to ignore user prompt
ENV DEBIAN_FRONTEND=noninteractive
Expand Down