Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build fails #36

Closed
vadi2 opened this issue Apr 22, 2022 · 4 comments · Fixed by #37
Closed

Docker build fails #36

vadi2 opened this issue Apr 22, 2022 · 4 comments · Fixed by #37

Comments

@vadi2
Copy link
Contributor

vadi2 commented Apr 22, 2022

See https://github.com/Mudlet/Mudlet/runs/6125396129?check_suite_focus=true - the docker build has started to fail for some reason.
@OrhanKupusoglu OrhanKupusoglu mentioned this issue Apr 25, 2022
Merged
9 tasks
@ZedThree
Copy link
Owner

Oops, we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all

Trivial fix, although it would change the versions of clang-tidy

@jellespijker
Copy link

This still fails, even when specifying ubuntu-20.04
Ultimaker/CuraEngine#1652

@ZedThree
Copy link
Owner

clang-tidy-review uses its own docker container, which is unrelated to the parent Action's container: https://github.com/Ultimaker/CuraEngine/runs/6175255484?check_suite_focus=true#step:2:5

I'll pin to ubuntu-20.04 for now.

ZedThree added a commit that referenced this issue Apr 26, 2022
@ZedThree
Pin container base to ubuntu:20.04 to ensure packages are available
46adfe8 
Fixes #36
@ZedThree ZedThree mentioned this issue Apr 26, 2022
Merged
@jellespijker
Copy link

thank you for the quick response and fix

alinaliBQ added a commit to aws/amazon-documentdb-odbc-driver that referenced this issue Apr 27, 2022
@alinaliBQ
[AD-721] resolve build error
9ee0264 
* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all . The fix would be changing it back to ubuntu-20.04
* for more details, see ZedThree/clang-tidy-review#36
@alinaliBQ alinaliBQ mentioned this issue Apr 27, 2022
Merged
3 tasks
alinaliBQ added a commit to aws/amazon-documentdb-odbc-driver that referenced this issue Apr 29, 2022
@alinaliBQ
[AD-721] resolve linux build error (#68)
0249517 
* [AD-721] resolve build error

* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all . The fix would be changing it back to ubuntu-20.04
* for more details, see ZedThree/clang-tidy-review#36

* [AD-721] updating PR template

* [AD-721] update checks.yml

* update to newest release: ZedThree/[email protected]

* [AD-721] change ubuntu version in docker file

* [AD-721] change ubuntu version in docker file

* revert back to 20.04. This is an attempt to resolve the build errors

* [AD-721] move clang check to linux build

* [AD-721] fix linux-build.yml

* [AD-721] remove checks.yml

* since we moved clang-tidy to somewhere else, checks.yml is no longer needed

* [AD-721] move clang-check after cppcheck

* [AD-721] generate compile_commands.json

* compile_commands.json is needed for clang to correctly find macros and .h files

* [AD-721] attempt to fix clang-tidy cmake command error

* [AD-721] upload pre-generated compile_commands.json for clang-tidy

* [AD-721] temporarily disable cmake_command in clang-tidy-review

* [AD-721] remove clang-tidy check

* add Jira ticket reference for enabling clang-tidy check (TODO)
affonsov pushed a commit to aws/amazon-documentdb-odbc-driver that referenced this issue Nov 16, 2022
@alinaliBQ
[AD-721] resolve linux build error (#68)
00e1026 
* [AD-721] resolve build error

* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all . The fix would be changing it back to ubuntu-20.04
* for more details, see ZedThree/clang-tidy-review#36

* [AD-721] updating PR template

* [AD-721] update checks.yml

* update to newest release: ZedThree/[email protected]

* [AD-721] change ubuntu version in docker file

* [AD-721] change ubuntu version in docker file

* revert back to 20.04. This is an attempt to resolve the build errors

* [AD-721] move clang check to linux build

* [AD-721] fix linux-build.yml

* [AD-721] remove checks.yml

* since we moved clang-tidy to somewhere else, checks.yml is no longer needed

* [AD-721] move clang-check after cppcheck

* [AD-721] generate compile_commands.json

* compile_commands.json is needed for clang to correctly find macros and .h files

* [AD-721] attempt to fix clang-tidy cmake command error

* [AD-721] upload pre-generated compile_commands.json for clang-tidy

* [AD-721] temporarily disable cmake_command in clang-tidy-review

* [AD-721] remove clang-tidy check

* add Jira ticket reference for enabling clang-tidy check (TODO)
affonsov pushed a commit to aws/amazon-documentdb-odbc-driver that referenced this issue Nov 17, 2022
@alinaliBQ
[AD-721] resolve linux build error (#68)
6ec7deb 
* [AD-721] resolve build error

* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all . The fix would be changing it back to ubuntu-20.04
* for more details, see ZedThree/clang-tidy-review#36

* [AD-721] updating PR template

* [AD-721] update checks.yml

* update to newest release: ZedThree/[email protected]

* [AD-721] change ubuntu version in docker file

* [AD-721] change ubuntu version in docker file

* revert back to 20.04. This is an attempt to resolve the build errors

* [AD-721] move clang check to linux build

* [AD-721] fix linux-build.yml

* [AD-721] remove checks.yml

* since we moved clang-tidy to somewhere else, checks.yml is no longer needed

* [AD-721] move clang-check after cppcheck

* [AD-721] generate compile_commands.json

* compile_commands.json is needed for clang to correctly find macros and .h files

* [AD-721] attempt to fix clang-tidy cmake command error

* [AD-721] upload pre-generated compile_commands.json for clang-tidy

* [AD-721] temporarily disable cmake_command in clang-tidy-review

* [AD-721] remove clang-tidy check

* add Jira ticket reference for enabling clang-tidy check (TODO)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin container base to ubuntu:20.04 to ensure packages are available ZedThree/clang-tidy-review
3 participants
@vadi2 @ZedThree @jellespijker