Skip to content

Commit

Permalink
[AD-721] resolve linux build error (#68)
Browse files Browse the repository at this point in the history
* [AD-721] resolve build error

* reason: we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all . The fix would be changing it back to ubuntu-20.04
* for more details, see ZedThree/clang-tidy-review#36

* [AD-721] updating PR template

* [AD-721] update checks.yml

* update to newest release: ZedThree/[email protected]

* [AD-721] change ubuntu version in docker file

* [AD-721] change ubuntu version in docker file

* revert back to 20.04. This is an attempt to resolve the build errors

* [AD-721] move clang check to linux build

* [AD-721] fix linux-build.yml

* [AD-721] remove checks.yml

* since we moved clang-tidy to somewhere else, checks.yml is no longer needed

* [AD-721] move clang-check after cppcheck

* [AD-721] generate compile_commands.json

* compile_commands.json is needed for clang to correctly find macros and .h files

* [AD-721] attempt to fix clang-tidy cmake command error

* [AD-721] upload pre-generated compile_commands.json for clang-tidy

* [AD-721] temporarily disable cmake_command in clang-tidy-review

* [AD-721] remove clang-tidy check

* add Jira ticket reference for enabling clang-tidy check (TODO)
  • Loading branch information
alinaliBQ authored Apr 29, 2022
1 parent 228e944 commit 0249517
Show file tree
Hide file tree
Showing 5 changed files with 1,446 additions and 15 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
### Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
<!-- Any additional reviewers -->
13 changes: 0 additions & 13 deletions .github/workflows/checks.yml

This file was deleted.

18 changes: 17 additions & 1 deletion .github/workflows/linux-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,23 @@ jobs:
cmake .. -DCMAKE_BUILD_TYPE=Release -DBSONCXX_POLY_USE_MNMLSTC=1 -DCMAKE_INSTALL_PREFIX=/usr/local
sudo make
sudo make install
# TODO enable clang-tidy-check
# https://bitquill.atlassian.net/browse/AD-726

# generate compile_commands.json file for clang-tidy-check, requires mongocxx and boost dependencies
# - name: generate-compile-commands-file
# run: |
# cmake "${{github.workspace}}/src" -DCMAKE_EXPORT_COMPILE_COMMANDS=on -DCMAKE_BUILD_TYPE=Release -DCODE_COVERAGE="OFF" -DBUILD_SHARED_LIBS="OFF" -DWITH_TESTS="ON" -DWITH_CORE="OFF" -DWITH_ODBC="ON"

# - name: clang-tidy-check
# uses: ZedThree/[email protected]
# id: review
# with:
# If there are any comments, fail the check
# - if: steps.review.outputs.total_comments > 0
# run: exit 1

- name: configure-and-build-driver
run: |
./build_linux_release64_deb.sh
Expand Down
Loading

0 comments on commit 0249517

Please sign in to comment.