Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable github actions on roblutt/windows-ci #47

Closed
wants to merge 13 commits into from

Conversation

roblutt
Copy link

@roblutt roblutt commented Oct 2, 2023

test

jusiskin and others added 11 commits October 6, 2023 15:07
…D/VIRTUAL

BREAKING CHANGES:
   The changes here are a result of breaking changes in the deadline-cloud library.
    - AssetLoadingMethod class is renamed to JobAttachmentsFileSystem
    - PRELOAD, ON_DEMAND enum string values for AssetLoadingMethod are now called COPIED, VIRTUAL

Signed-off-by: Phanindra Bhagavatula <[email protected]>
- `BatchGetJobEntity` API response data validation
- `ConfigFile` model validation (pydantic)
- `Capabilities` model validation (pydantic)

Signed-off-by: Gahyun Suh <[email protected]>
When calling a deadline cloud service API and getting a throttle/retry
response the exception object may contain a "retryAfterSeconds" field
alongside the error. When that field is present, the calling client
should treat that as a request to retry in no sooner than the given number
of seconds; it is a load-shedding mechanism for the service. We should
respect the service's request.

Solution:
 Added to the logic of all of the deadline-cloud API wrappers to have
them extract the value of the "retryAfterSeconds" field if it's present,
and pass that to our backoff-delay calculator. We use the value as a
lower limit on the returned delay.
 I also made the scheduler use the API wrapper for update_worker; it
still had its own implementation that didn't properly handle exceptions.
This necessitated adding the ability to interrupt the update_worker's
throttled-retries so preserve the functionality at that call site.

Signed-off-by: Daniel Neilson <[email protected]>
Signed-off-by: Jericho Tolentino <[email protected]>
@roblutt roblutt force-pushed the roblutt/windev branch 2 times, most recently from 33c9c44 to c81b35b Compare October 19, 2023 08:02
@roblutt roblutt force-pushed the roblutt/windev branch 4 times, most recently from 67fe9ed to d898506 Compare October 19, 2023 23:05
@roblutt roblutt closed this Nov 8, 2023
@roblutt roblutt deleted the roblutt/windev branch March 4, 2024 18:19
jusiskin added a commit to jusiskin/deadline-cloud-worker-agent that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants