-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: session lifecycle log improvements #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahyusuh
approved these changes
Oct 6, 2023
ddneilson
approved these changes
Oct 6, 2023
godobyte
reviewed
Oct 6, 2023
godobyte
approved these changes
Oct 6, 2023
Signed-off-by: Josh Usiskin <[email protected]>
jusiskin
force-pushed
the
jusiskin/log_completed_session_actions
branch
from
October 6, 2023 20:36
66f5813
to
668a76f
Compare
ddneilson
approved these changes
Oct 6, 2023
gmchale79
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gahyusuh
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]> Signed-off-by: Gahyun Suh <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
jusiskin
added a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Josh Usiskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The worker agent logs for session lifecycle events was ad-hoc and inconsistent
The previous PR (#49) was intended to include changes that were missed. That PR description has since been edited to reflect the actual changes made.
What was the solution? (How)
Made the logging message formatting structure consistent. The format for session events is:
Where:
<SESSION_ID>
— The unique identifier for the session<SESSIONACTION_ID>
— The unique identifier for the session action<SESSIONACTION_HUMAN_READABLE>
— A more human-friendly representation of the session action that denotes the job model entity that the action definition belongs to<MSG>
— The event messageAn example of the new session log is:
What is the impact of this change?
How was this change tested?
Was this change documented?
No
Is this a breaking change?
Yes, log formatting has changed