-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log session action completion events #49
Conversation
Signed-off-by: Josh Usiskin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid improvement, Josh. However, this -- environment[STEP:step-e404e034a52846809db3ec250ea82f48:myenv].enter()
-- sort of message in the log has been identified as being the opposite of human readable; there's a ticket that calls it out explicitly. It's readable to programmer-minded individuals, but little else.
Do you have thoughts on how that can also be improved?
One idea: environment[STEP:step-e404e034a52846809db3ec250ea82f48:myenv].enter()
-> "[<stepid>] Entering Environment: myenv"
. Ideal might have been "Entering Step/Job/External Environment...", but the Worker doesn't have that context.
Let's take this improvement as a followup. |
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]> Signed-off-by: Gahyun Suh <[email protected]>
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Signed-off-by: Josh Usiskin <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Signed-off-by: Josh Usiskin <[email protected]>
What was the problem/requirement? (What/Why)
Session action completion events were not being logged
What was the solution? (How)
Added logic for logging session action completion events.
What is the impact of this change?
All session and session action lifecycle events are now emitted
How was this change tested?
Was this change documented?
No
Is this a breaking change?
No