update #2
Merged
update #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add basic support for native Hue sensors * Update coveragerc * Simplify attributes * Remove config option * Refactor and document device-ness and update mechanism * Entity docstrings * Remove lingering config for sensors * Whitespace * Remove redundant entity ID generation and hass assignment. * More meaningful variable name. * Add new 'not-darkness' pseudo-sensor. * Refactor sensors into separate binary, non-binary, and shared modules. * formatting * make linter happy. * Refactor again, fix update mechanism, and address comments. * Remove unnecessary assignment * Small fixes. * docstring * Another refactor: only call API once and make testing easier * Tests & test fixes * Flake & lint * Use gather and dispatcher * Remove unnecessary whitespace change. * Move component related stuff out of the shared module * Remove unused remnant of failed approach. * Increase test coverage * Don't get too upset if we're already trying to update an entity before it has finished adding * relative imports
* Skip entity if no device type found * Add test for potentially skipped binary sensors * Reorg code, add tests to ensure all exposed things have types * Lint * Fix tests * Lint
* Upgrade niko-home-control library * Fix additional feedback * Lint
* Added minimum/maximum to counter * Added min/max testcases * remove duplicate * cosmetic changes * removed blank lines at eof * added newline at eof * type cv -> vol * more fixes * - fixed min/max warnings - fixed failing tests * Added linewrap * - Added cast to int - Fixed double quotes * - removed None check in __init__ - fixed failing test * copy paste fix * copy paste fix * Added possibility to change counter properties trough service call * fixed copy paste errors * Added '.' to comment * rephrased docstring * Fix tests after rebase * Clean up per previous code review comments * Replace setup service with configure * Update services description * Update tests to use configure instead of setup
* Adds Orange Pi GPIO platform * Add manifest.json * Remove cover platform * Apply requested changes * Remove switch platform * Update CODEOWNERS * Remove obsolete dependecies/requirements
* configuration for hub tokens are now separate from host addresses/credentials * small change to docstring * use *args **kwargs
* handle the off part of on with timed off command * use correct var * only bind / configure cluster once * clean up channel configuration * additional debug logging * add guard * prevent multiple discoveries for a device * cleanup and still configure on rejoin
* set myself as codeowner of xmpp, removed me from notify/* * changed the manifests as well
* Create services.yaml for python_script * Create services.yaml for script
* Add services.yaml validator * Fix path
#22294) * update vizio component to support latest pyvizio with soundbar support * Resolved Hound issues * Additional Hound issue * Updated based on feedback * Style updates * Additional code styling changes * Added check for auth token not being set for tv device_class * Limited lines to 80 characters * moved MAX_VOLUME into base package * fixed supported commands * styling changes * fix styling yet again * remove unnecessary elif * removed play/pause since I can't get current state * changed value access method from config dict * fixed flake failures * try to fix docstring * try to fix docstring * fixed auth token validation * rebase and regenerate requirements_all.txt * updated log text * line length fix * added config validation to handle conditionally optional parameter * updated validate setup log message and string formatting based on review * fix pylint error * less ugly
* Allow host/ipv6 address for broadlink service This matches switch config and is a regression fix * Restore padding of packets for broadlink * Drop unused import * Fix comment on test
…23419) * Correct media player feature gates * Fix failing test * Lint...
* Refactor NETATMO_AUTH to use hass.data * Minor cleanup * Rename conf to auth and other suggestions by Martin * Revert webhook name change * Rename constant * Move auth * Don't use hass.data.get() * Fix auth string
* Fix Flux component * Update manifest.json * Update manifest.json
* Additional cleanup of IQVIA integration * Task * Moved import * Fixed exception * Member comments (round 1) * Member comments (round 2) * Member comments
Fix daikin setup
Fix point setup
* Make setup more robust * Fix typing
austinmroczek
pushed a commit
that referenced
this pull request
Jun 7, 2019
* Add support for DoorLock cluster * Add test for zha lock * Change lock_state report to REPORT_CONFIG_IMMEDIATE * Update channel command wrapper to return the entire result This allows for return values other than result[1] * Fix tests * Fix lint * Update DoorLock test to work with updated zigpy schema * Fix lint * Fix unlock test
austinmroczek
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Config Flow for sense * Fix unique ids so they are actually unique (and migrate the old ones) * Fix missing solar production * Do not mark sensors available until they have data * Address review items * Address review round #2
austinmroczek
pushed a commit
that referenced
this pull request
Mar 9, 2021
…nt#46463) * Add get_configuration_values websocket command to zwave_js * Tweak return value * Review comments and cleanup returned values * Update test * Rename to get_config_parameters * Add get_configuration_values websocket command to zwave_js * Rename to get_config_parameters * fix test * fix tests #2 * Add readable to metadata Co-authored-by: Raman Gupta <[email protected]>
austinmroczek
pushed a commit
that referenced
this pull request
May 1, 2021
* Add suggested_area to MQTT Discovery This adds suggested_area to MQTT discovery, so that the discovered devices could be automatically added to the proper area. * Add abbreviation for MQTT suggested_area * Remove extra whitespace * Remove extra whitespace #2 * Added tests for MQTT Dicovery of suggested_area * Fix test for MQTT suggested_area * Better tests of MQTT suggested_area Changes made as per feedback from @emontnemery
austinmroczek
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Remove old migrations from KNX integration * Remove cover migration
austinmroczek
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Bump aioshelly * Bump fritzconnection and remove workarounds * Cleanup fritzbox_callmonitor * Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Update homeassistant/components/shelly/utils.py Co-authored-by: Shay Levy <[email protected]> * Update homeassistant/components/shelly/__init__.py Co-authored-by: Shay Levy <[email protected]> * Revert slipped in commit * Rename param * Apply review comment * Apply comment review #2 Co-authored-by: Shay Levy <[email protected]>
austinmroczek
pushed a commit
that referenced
this pull request
Jan 23, 2022
austinmroczek
pushed a commit
that referenced
this pull request
Jan 23, 2022
austinmroczek
pushed a commit
that referenced
this pull request
Jan 23, 2022
…t#63522)" (home-assistant#63561) This reverts commit 1baa3d8.
austinmroczek
pushed a commit
that referenced
this pull request
Jun 4, 2022
* First version of laundrify integration * Code cleanup * Code cleanup after review #2 * Move coordinator to its own file * Save devices as dict and implement available prop as fn * Validate token on init, abort if already configured * Some more cleanup after review * Add strict type hints * Minor changes after code review * Remove OptionsFlow (use default poll interval instead) * Fix CODEOWNERS to pass hassfest job * Fix formatting to pass prettier job * Fix mypy typing error * Update internal device property after fetching data * Call parental update handler and remove obsolete code * Add coordinator tests and fix some config flow tests * Refactor tests * Refactor fixtures * Device unavailable if polling fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: