Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional cleanup of IQVIA integration #23403

Merged
merged 7 commits into from
Apr 26, 2019
Merged

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Apr 25, 2019

Description:

This PR follows up on #22986 and addresses @MartinHjelmare's feedback.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

iqvia:
  zip_code: "12345"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

homeassistant/components/iqvia/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iqvia/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iqvia/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iqvia/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iqvia/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iqvia/sensor.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bachya bachya merged commit 8fe95f4 into home-assistant:dev Apr 26, 2019
@bachya bachya deleted the iqvia-cleanup branch April 26, 2019 17:07
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants