Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump youtube-dl version to 2019.04.24 #23398

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Apr 25, 2019

Description:

media_extractor is currently broken due to YouTube backend changes. There was a youtube-dl update released yesterday that resolves this issue, so the version included in HA needs to be updated to 2019.04.24 otherwise YouTube videos will fail.

Thanks @SeanPM5

Related issue (if applicable): fixes #23393

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit d2e0c6d into home-assistant:dev Apr 25, 2019
@balloob balloob mentioned this pull request May 14, 2019
@cgtobi cgtobi deleted the upgrade-youtube-dl branch August 25, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media_extractor broken due to YouTube change, requires updated youtube-dl
3 participants