Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stub services.yaml and make validation mandatory #23213

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Add stub services.yaml and make validation mandatory #23213

merged 1 commit into from
Apr 18, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 18, 2019

Description:

Add empty services.yaml files for integrations that register services. We will still be better off having the actual service description being entered, but it's an ok start.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.92.0 milestone Apr 18, 2019
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Apr 18, 2019
@balloob balloob merged commit a52f96b into dev Apr 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-stub-servicesyaml-files branch April 18, 2019 22:13
@balloob balloob mentioned this pull request Apr 18, 2019
Closed
balloob added a commit that referenced this pull request Apr 20, 2019
@balloob
Add stub services.yaml and make validation mandatory (#23213)
4433ad0
fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
@balloob
Add stub services.yaml and make validation mandatory (home-assistant#…
7e6c6a6 
…23213)
fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
@balloob
Add stub services.yaml and make validation mandatory (home-assistant#…
fe31356 
…23213)
fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
@balloob
Add stub services.yaml and make validation mandatory (home-assistant#…
8cc96ad 
…23213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amelchio amelchio Awaiting requested review from amelchio

@andrey-git andrey-git Awaiting requested review from andrey-git andrey-git is a code owner

@emlove emlove Awaiting requested review from emlove

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@ludeeus ludeeus Awaiting requested review from ludeeus ludeeus is a code owner

@robbiet480 robbiet480 Awaiting requested review from robbiet480

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@syssi syssi Awaiting requested review from syssi syssi is a code owner

Assignees
No one assigned
Labels
cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.92.0
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant