Add support for --dry-run mode in uv lock
#7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfsingh
commented
Sep 29, 2024
| // If the user specified `--upgrade-package`, then at best we can prefer some of | ||
| // the existing versions. | ||
| return Ok(Self::Preferable(lock)); | ||
| if !dry_run { |
There was a problem hiding this comment.
If we don't do this check, when we use --dry-run with -U the caller (do_lock) will indicate there was an update even if there wasn't one.
I'm not the happiest with this change as it pollutes the do_lock and validate APIs. That being said, I'm not sure of a better approach (doesn't make sense to include dry_run as a variant/member of one of the enums/structs passed in imo, they all seem to be used quite widely) — open to suggestions!
charliermarsh
force-pushed
the
tfsingh/dry
branch
from
54d027e
to
6c71ce1
Compare
charliermarsh
approved these changes
Oct 24, 2024
charliermarsh
changed the title
--dry-run mode in uv lock
charliermarsh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
uv lock --dry-run, as described in issue #6408.One thing to note: this functionality, as implemented, isn't limited to
-U(if someone adds a dependency to the project'spyproject.toml, the plan will include these changes).