do not imply pre-release when != operator is used
#7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right to me! It will need to be part of 0.5.0 so I'll add it to that milestone. |
charliermarsh
approved these changes
Oct 9, 2024
|
I think you could write a test like |
Czaki
commented
Oct 10, 2024
crates/uv-resolver/src/prerelease.rs
Outdated
| @@ -84,6 +84,7 @@ impl PrereleaseStrategy { | |||
|
|
|||
| if specifier | |||
| .iter() | |||
| .filter(|spec| (spec.operator() != &Operator::NotEqual)) | |||
There was a problem hiding this comment.
@charliermarsh I just spot that there is NotEqualStar operator also defined. Should I add it here? Is flask!=2.0.0rc* valid inequality?
There was a problem hiding this comment.
Yeah, I think you should add that here too.
crates/uv-resolver/src/prerelease.rs
Outdated
| .filter(|spec| (spec.operator() != &Operator::NotEqual)) | ||
| .filter(|spec| { | ||
| (spec.operator() != &Operator::NotEqual) | ||
| && (spec.operator() != &Operator::NotEqualStar) |
There was a problem hiding this comment.
You might be interested in something like: !matches!(spec.operator(), Operator::NotEqual | Operator::NotEqualStar)
|
@Czaki it looks like this has some unrelated changes in it now. |
|
I backed them out. @zanieb, want to merge into 0.5 branch? |
One of the most common and most diverse are errors users encounter in Python packaging are build failures. They usually show lengthy, sometimes nested stack traces with no clear indication of what went wrong and how to fix it, while blocking the user. We already catch four common cases with dedicated, actionable help messages. For all other errors, we link to a dedicated help page enumerating typical causes and their solutions.
Co-authored-by: Charles Tapley Hoyt <[email protected]>
charliermarsh
force-pushed
the
fix_ne_pre
branch
from
f4a0c88
to
f2b97a1
Compare
zanieb
approved these changes
Oct 21, 2024
zanieb
pushed a commit
that referenced
this pull request
Oct 21, 2024
closes #6640 Could you suggest how I should test it? (already tested locally) --------- Co-authored-by: konstin <[email protected]> Co-authored-by: Charles Tapley Hoyt <[email protected]> Co-authored-by: Charlie Marsh <[email protected]>
zanieb
pushed a commit
that referenced
this pull request
Oct 22, 2024
closes #6640 Could you suggest how I should test it? (already tested locally) --------- Co-authored-by: konstin <[email protected]> Co-authored-by: Charles Tapley Hoyt <[email protected]> Co-authored-by: Charlie Marsh <[email protected]>
Merged
zanieb
pushed a commit
that referenced
this pull request
Oct 24, 2024
closes #6640 Could you suggest how I should test it? (already tested locally) --------- Co-authored-by: konstin <[email protected]> Co-authored-by: Charles Tapley Hoyt <[email protected]> Co-authored-by: Charlie Marsh <[email protected]>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #6640
Test Plan
Could you suggest how I should test it?
(already tested locally)