Fix hard float detection #8498
Open
Fix hard float detection #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
approved these changes
Oct 23, 2024
zanieb
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fix the errouneous detection of
vfpfrom the cpu info.The commit aims to fix issue #6873 integrating PR7725 developed by @kakkoyun
Test Plan
I've tested locally on my hardware, now it fails with:
❯ RUST_LOG=trace cargo run python install 3.12 --verbose Compiling uv-python v0.0.1 (/home/synapsees/source/uv/crates/uv-python) Compiling uv-types v0.0.1 (/home/synapsees/source/uv/crates/uv-types) Compiling uv-virtualenv v0.0.4 (/home/synapsees/source/uv/crates/uv-virtualenv) Compiling uv-distribution v0.0.1 (/home/synapsees/source/uv/crates/uv-distribution) Compiling uv-build-frontend v0.0.1 (/home/synapsees/source/uv/crates/uv-build-frontend) Compiling uv-resolver v0.0.1 (/home/synapsees/source/uv/crates/uv-resolver) Compiling uv-installer v0.0.1 (/home/synapsees/source/uv/crates/uv-installer) Compiling uv-settings v0.0.1 (/home/synapsees/source/uv/crates/uv-settings) Compiling uv-requirements v0.1.0 (/home/synapsees/source/uv/crates/uv-requirements) Compiling uv-dispatch v0.0.1 (/home/synapsees/source/uv/crates/uv-dispatch) Compiling uv-cli v0.0.1 (/home/synapsees/source/uv/crates/uv-cli) Compiling uv-tool v0.0.1 (/home/synapsees/source/uv/crates/uv-tool) Compiling uv-scripts v0.0.1 (/home/synapsees/source/uv/crates/uv-scripts) Compiling uv v0.4.16 (/home/synapsees/source/uv/crates/uv) Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 55s Running `target/debug/uv python install 3.12 --verbose` DEBUG uv 0.4.16 TRACE Checking lock for `/home/synapsees/.local/share/uv/python` at `/home/synapsees/.local/share/uv/python/.lock` DEBUG Acquired lock for `/home/synapsees/.local/share/uv/python` WARN Ignoring malformed managed Python entry: Failed to parse Python installation key `cpython-3.12.6-linux-armv7-gnueabihf`: invalid libc: Unknown libc environment: gnueabihf WARN Ignoring malformed managed Python entry: eabi Searching for Python versions matching: Python 3.12 TRACE ld path: /lib/ld-linux-armhf.so.3 TRACE stdout output from `ld`: "" DEBUG Using request timeout of 30s DEBUG Released lock at `/home/synapsees/.local/share/uv/python/.lock` error: Failed to parse Python installation key `cpython-3.12.6-linux-armv7-gnueabihf`: invalid libc: Unknown libc environmentBut I believe this is due to #7975, already fixed by @zanieb therefore I would expect that once the changes are rebased everything should work.