-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install versioned Python executables into the bin directory during uv python install
#8458
base: tracking/050
Are you sure you want to change the base?
Conversation
uv python install
b3f1ede
to
dc70ac5
Compare
dc70ac5
to
a5bae91
Compare
a5bae91
to
b188781
Compare
1396487
to
6bd04ee
Compare
6bd04ee
to
3157909
Compare
3157909
to
cb814eb
Compare
// Workaround for python-build-standalone v20241016 which is missing the standard | ||
// `python.exe` executable in free-threaded distributions on Windows. | ||
// | ||
// See https://github.com/astral-sh/uv/issues/8298 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moved up, so executable
always returns the existing executable for an installation and we ensure all the canonical names exist here.
let canonical_names = &["python"]; | ||
|
||
for name in canonical_names { | ||
let executable = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactored for future changes.
With a change like #8458, we really need tests for these. I'm just going to take the possible performance hit of these slow tests and deal with optimizing them separately.
This comment was marked as outdated.
This comment was marked as outdated.
cb814eb
to
b07af00
Compare
b07af00
to
c2094b4
Compare
eda0f05
to
b3758f8
Compare
b3758f8
to
2622e4e
Compare
2622e4e
to
773a706
Compare
773a706
to
be7b474
Compare
8a5e932
to
712bbdc
Compare
…v python install`
712bbdc
to
6bf47d0
Compare
Updates
uv python install
to linkpython3.x
in the executable directory (i.e.,~/.local/bin
) to the the managed interpreter path. In a future change, we'll add a--default
flag that will includepython
andpython3
links.On Windows, we create a copy. I think we need to create a trampoline instead though?
Needs documentation changes and removal on uninstall.