Install versioned Python executables into the bin directory during uv python install
#8458
+352
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
changed the title
uv python install
zanieb
force-pushed
the
zb/python-exec-dir
branch
4 times, most recently
from
b3f1ede
to
dc70ac5
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
dc70ac5
to
a5bae91
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
a5bae91
to
b188781
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
2 times, most recently
from
1396487
to
6bd04ee
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
6bd04ee
to
3157909
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
3157909
to
cb814eb
Compare
zanieb
commented
Oct 22, 2024
Comment on lines
-339
to
-342
| // Workaround for python-build-standalone v20241016 which is missing the standard | ||
| // `python.exe` executable in free-threaded distributions on Windows. | ||
| // | ||
| // See https://github.com/astral-sh/uv/issues/8298 |
There was a problem hiding this comment.
This moved up, so executable always returns the existing executable for an installation and we ensure all the canonical names exist here.
zanieb
commented
Oct 22, 2024
Comment on lines
+412
to
+419
| let canonical_names = &["python"]; | ||
|
|
||
| for name in canonical_names { | ||
| let executable = |
There was a problem hiding this comment.
This refactored for future changes.
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
added a commit
that referenced
this pull request
Oct 24, 2024
With a change like #8458, we really need tests for these. I'm just going to take the possible performance hit of these slow tests and deal with optimizing them separately.
This comment was marked as outdated.
This comment was marked as outdated.
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
cb814eb
to
b07af00
Compare
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
b07af00
to
c2094b4
Compare
Draft
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
2 times, most recently
from
eda0f05
to
b3758f8
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
b3758f8
to
2622e4e
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
2622e4e
to
773a706
Compare
zanieb
had a problem deploying
to
uv-test-publish
GitHub Actions
Failure
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
773a706
to
be7b474
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/python-exec-dir
branch
2 times, most recently
from
8a5e932
to
712bbdc
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
…v python install`
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
712bbdc
to
6bf47d0
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
uv python installto linkpython3.xin the executable directory (i.e.,~/.local/bin) to the the managed interpreter path. In a future change, we'll add a--defaultflag that will includepythonandpython3links.On Windows, we create a copy. I think we need to create a trampoline instead though?
Needs documentation changes and removal on uninstall.